From: Eric Sesterhenn <snakebyte@gmx.de>
To: linux-kernel@vger.kernel.org
Cc: khc@pm.waw.pl
Subject: [Patch] Missing return in drivers/net/wan/pci200syn.c
Date: Wed, 21 Jun 2006 15:49:27 +0200 [thread overview]
Message-ID: <1150897767.306.1.camel@alice> (raw)
hi,
if card->plxbase == NULL we call the cleanup function
pci200_pci_remove_one() but continue initializing
the driver and dereferencing the pointer. This
was found by coverity (bug id #195)
Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
--- linux-2.6.17-git2/drivers/net/wan/pci200syn.c.orig 2006-06-21 15:45:52.000000000 +0200
+++ linux-2.6.17-git2/drivers/net/wan/pci200syn.c 2006-06-21 15:46:12.000000000 +0200
@@ -358,6 +358,7 @@ static int __devinit pci200_pci_init_one
card->rambase == NULL) {
printk(KERN_ERR "pci200syn: ioremap() failed\n");
pci200_pci_remove_one(pdev);
+ return -EFAULT;
}
/* Reset PLX */
reply other threads:[~2006-06-21 13:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1150897767.306.1.camel@alice \
--to=snakebyte@gmx.de \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome