From: Arjan van de Ven <arjan@infradead.org>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: akpm@osdl.org, torvalds@osdl.org
Subject: Re: [PATCH] x86: cache pollution aware __copy_from_user_ll()
Date: Sat, 24 Jun 2006 16:42:32 +0200 [thread overview]
Message-ID: <1151160152.3181.59.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <200606231501.k5NF1B79002899@hera.kernel.org>
On Fri, 2006-06-23 at 15:01 +0000, Linux Kernel Mailing List wrote:
> commit c22ce143d15eb288543fe9873e1c5ac1c01b69a1
> tree dc7d457b8952fc50dfc90df659b35de4117c61fc
> parent 7dbdf43cfa635ddc3701cc8d1eab07597cd731c0
> author Hiro Yoshioka <hyoshiok@miraclelinux.com> Fri, 23 Jun 2006 16:04:16 -0700
> committer Linus Torvalds <torvalds@g5.osdl.org> Fri, 23 Jun 2006 21:42:56 -0700
>
> [PATCH] x86: cache pollution aware __copy_from_user_ll()
>
> Use the x86 cache-bypassing copy instructions for copy_from_user().
>
> Some performance data are
>
> Total of GLOBAL_POWER_EVENTS (CPU cycle samples)
>
> 2.6.12.4.orig 1921587
> 2.6.12.4.nt 1599424
> 1599424/1921587=83.23% (16.77% reduction)
Hi,
while this patch will reduce the number of cycles spent in the kernel,
it's just pushing the cache miss to userspace (by virtue of doing a
cache flush effectively)... is this really the right thing? The total
memory bandwidth will actually increase with this patch if you're
unlucky (eg if userspace decides to write to this memory eventually)....
Greetings,
Arjan van de Ven
next parent reply other threads:[~2006-06-24 14:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200606231501.k5NF1B79002899@hera.kernel.org>
2006-06-24 14:42 ` Arjan van de Ven [this message]
2006-06-24 17:39 ` Dave Jones
2006-06-24 19:21 ` Linus Torvalds
2006-06-24 19:32 ` Arjan van de Ven
2006-06-26 20:26 ` Andi Kleen
2006-06-26 20:31 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151160152.3181.59.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®