From: Arjan van de Ven <arjan@infradead.org>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux1394-devel@lists.sourceforge.net,
Ben Collins <bcollins@ubuntu.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ieee1394: dv1394: sem2mutex conversion
Date: Sat, 24 Jun 2006 19:42:55 +0200 [thread overview]
Message-ID: <1151170975.3181.73.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <tkrat.7092f9b969592375@s5r6.in-berlin.de>
On Sat, 2006-06-24 at 19:37 +0200, Stefan Richter wrote:
>
> - if (down_trylock(&video->sem)) {
> + if (mutex_trylock(&video->mtx)) {
this is a bug!
mutex_trylock follows the spinlock trylock convention, not the semaphore
trylock convention!!!
next prev parent reply other threads:[~2006-06-24 17:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-24 17:37 Stefan Richter
2006-06-24 17:42 ` Arjan van de Ven [this message]
2006-06-24 18:02 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151170975.3181.73.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=bcollins@ubuntu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®