From: David Woodhouse <dwmw2@infradead.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
juha.yrjola@solidboot.com
Subject: Re: [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static
Date: Tue, 27 Jun 2006 14:49:00 +0100 [thread overview]
Message-ID: <1151416141.17609.140.camel@hades.cambridge.redhat.com> (raw)
In-Reply-To: <20060626220215.GI23314@stusta.de>
On Tue, 2006-06-27 at 00:02 +0200, Adrian Bunk wrote:
> This patch makes the needlessly global mtdpart_setup() static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.17-mm2-full/drivers/mtd/cmdlinepart.c.old 2006-06-26 23:18:39.000000000 +0200
> +++ linux-2.6.17-mm2-full/drivers/mtd/cmdlinepart.c 2006-06-26 23:18:51.000000000 +0200
> @@ -346,7 +346,7 @@
> *
> * This function needs to be visible for bootloaders.
> */
> -int mtdpart_setup(char *s)
> +static int mtdpart_setup(char *s)
Patch lacks sufficient explanation. Explain the relevance of the comment
immediately above the function declaration, in the context of your
patch. Explain your decision to change the behaviour, but not change the
comment itself.
Think. Or you will be replaced with a small shell script.
--
dwmw2
next prev parent reply other threads:[~2006-06-27 13:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-26 22:02 Adrian Bunk
2006-06-27 13:49 ` David Woodhouse [this message]
2006-06-29 17:32 ` Adrian Bunk
2006-07-09 9:12 ` David Woodhouse
2006-07-09 16:12 ` Juha Yrjölä
2006-07-10 10:56 ` Sergei Shtylyov
2006-07-10 11:37 ` David Woodhouse
2006-11-25 19:15 Adrian Bunk
2006-11-28 22:19 ` David Woodhouse
2006-11-30 18:45 ` Andy Isaacson
2006-12-01 13:41 ` Jarkko Lavinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151416141.17609.140.camel@hades.cambridge.redhat.com \
--to=dwmw2@infradead.org \
--cc=bunk@stusta.de \
--cc=juha.yrjola@solidboot.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®