mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andy Gay <andy@andynet.net>
To: Greg KH <gregkh@suse.de>
Cc: Jeremy Fitzhardinge <jeremy@goop.org>,
	linux-kernel@vger.kernel.org,
	linux-usb-devel@lists.sourceforge.net
Subject: USB driver for Sierra Wireless EM5625/MC5720 1xEVDO modules
Date: Wed, 28 Jun 2006 19:27:27 -0400	[thread overview]
Message-ID: <1151537247.3285.278.camel@tahini.andynet.net> (raw)

I have adapted the modified Airprime driver that Greg posted a few weeks
ago to add support for these 2 modules.

That driver works for these modules if the USB IDs are added, and fixes
the throughput problems in the earlier driver. I had to make some
changes though -

- there's a memory leak because the transfer buffers are kmalloc'ed
every time the device is opened, but they're never freed;

- these modules present 3 bulk EPs, the 2nd & 3rd can be used for
control & status monitoring while data transfer is in progress on the
1st EP. This is useful (and necessary for my application) so we need to
increase the port count.

So what should I do next? I see a few possibilities, assuming anyone is
interested in this:

- I could post a diff from Greg's driver. But I don't have hardware to
test whether my changes will break it for the other devices that it
supports;

- I could post it as a new driver for just these 2 modules, using some
other name;

- I could post it as a replacement for Greg's driver (which isn't yet in
the official sources, I think), including all the USB IDs, if someone
can test it for the other devices.

Any preference, anyone?

(Please CC replies. Thanks.)

- Andy



             reply	other threads:[~2006-06-28 23:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-28 23:27 Andy Gay [this message]
2006-06-29  0:11 ` Jeremy Fitzhardinge
2006-06-29  2:31   ` Andy Gay
2006-06-29  3:00 ` [linux-usb-devel] " Ken Brush
2006-06-30  2:13 ` Greg KH
2006-06-30  2:40   ` Roland Dreier
2006-06-30  2:51     ` Andy Gay
2006-06-30  3:02       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1151537247.3285.278.camel@tahini.andynet.net \
    --to=andy@andynet.net \
    --cc=gregkh@suse.de \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®