mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Martin Filip <bugtraq@smoula.net>
To: Neil Brown <neilb@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: NFS and partitioned md
Date: Thu, 29 Jun 2006 18:01:11 +0200	[thread overview]
Message-ID: <1151596871.16253.2.camel@archon.smoula-in.net> (raw)
In-Reply-To: <17571.19699.980491.970386@cse.unsw.edu.au>

Hi,

Neil Brown píše v Čt 29. 06. 2006 v 13:45 +1000:
> Exactly.  4105 > 256.  Such devices need a different format filehandle
> which didn't work until very recently due to a bug (obviously no-one
> tried it until recently).
> 
> The patch below fixes the kernel so that this will work.

I'm affraid the problem will be yet somewhere else. I've tried this
patch and the result is totaly same :(


> -----------------------------
> Fixing missing 'expkey' support for fsid type 3
> 
> From: Frank Filz <ffilzlnx@us.ibm.com>
> 
> Type '3' is used for the fsid in filehandles when the device number
> of the device holding the filesystem has more than 8 bits in either
> major or minor.
> Unfortunately expkey_parse doesn't recognise type 3.  Fix this.
> 
> (Slighty modified from Frank's original)
> 
> Signed-Off-By: Frank Filz <ffilzlnx@us.ibm.com>
> Signed-off-by: Neil Brown <neilb@suse.de>
> 
> ### Diffstat output
>  ./fs/nfsd/export.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff .prev/fs/nfsd/export.c ./fs/nfsd/export.c
> --- .prev/fs/nfsd/export.c	2006-06-29 11:07:21.000000000 +1000
> +++ ./fs/nfsd/export.c	2006-06-27 18:27:49.000000000 +1000
> @@ -126,7 +126,7 @@ static int expkey_parse(struct cache_det
>  	if (*ep)
>  		goto out;
>  	dprintk("found fsidtype %d\n", fsidtype);
> -	if (fsidtype > 2)
> +	if (key_len(fsidtype)==0) /* invalid type */
>  		goto out;
>  	if ((len=qword_get(&mesg, buf, PAGE_SIZE)) <= 0)
>  		goto out;
> -

-- 
Martin Filip
e-mail: nexus@smoula.net
ICQ#: 31531391
jabber: nexus@smoula.net
www: http://www.smoula.net

 _______________________________________ 
< BOFH Excuse #20: divide-by-zero error >
 --------------------------------------- 
       \   ,__,
        \  (oo)____
           (__)    )\
              ||--|| *


  reply	other threads:[~2006-06-29 16:01 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-26 20:52 Martin Filip
2006-06-26 20:58 ` Trond Myklebust
2006-06-26 21:21   ` Martin Filip
     [not found]   ` <1151356840.4460.18.camel@archon.smoula-in.net>
2006-06-26 21:51     ` Trond Myklebust
2006-06-26 22:14       ` Martin Filip
2006-06-26 22:32         ` Trond Myklebust
2006-06-27  0:32 ` Neil Brown
2006-06-27 18:18   ` Martin Filip
2006-06-29  3:45     ` Neil Brown
2006-06-29 16:01       ` Martin Filip [this message]
2006-07-18 18:36       ` David Greaves
2006-07-18 20:04         ` Martin Filip
2006-07-20  0:30           ` Neil Brown
2006-07-20  9:07             ` Frank van Maarseveen
2006-08-21  2:29               ` [NFS] " Neil Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1151596871.16253.2.camel@archon.smoula-in.net \
    --to=bugtraq@smoula.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®