From: Trond Myklebust <trond.myklebust@fys.uio.no>
To: "Vladimir V. Saveliev" <vs@namesys.com>
Cc: lkml <Linux-Kernel@vger.kernel.org>
Subject: Re: [RFC] [PATCH] do_sys_truncate: call do_truncate with ATTR_MTIME|ATTR_CTIME
Date: Fri, 30 Jun 2006 09:59:15 -0400 [thread overview]
Message-ID: <1151675955.2276.5.camel@lade.trondhjem.org> (raw)
In-Reply-To: <1151674409.6499.52.camel@tribesman.namesys.com>
On Fri, 2006-06-30 at 17:33 +0400, Vladimir V. Saveliev wrote:
> Hello
>
> do_sys_ftruncate calls do_truncate with time_attrs set to ATTR_MTIME|
> ATTR_CTIME. Is there a reason for do_sys_truncate to not set time_attrs
> to the same value or it is a bug?
It would be a bug.
In the case of truncate(), the filesystem has to decide if the file size
will actually change. If it does, then it has to update mtime/ctime. In
the case of ftruncate(), it would appear that the filesystem always has
to update mtime/ctime on success, so it is appropriate to call
do_truncate with ATTR_MTIME/ATTR_CTIME.
Cheers,
Trond
> email message attachment (do_truncate-time_attrs.patch)
> > -------- Forwarded Message --------
> > Subject: No Subject
> > Date: Fri, 30 Jun 2006 17:33:29 +0400
> >
prev parent reply other threads:[~2006-06-30 13:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-30 13:33 Vladimir V. Saveliev
2006-06-30 13:59 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151675955.2276.5.camel@lade.trondhjem.org \
--to=trond.myklebust@fys.uio.no \
--cc=Linux-Kernel@vger.kernel.org \
--cc=vs@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®