From: Arjan van de Ven <arjan@infradead.org>
To: Stephen.Clark@seclark.us
Cc: "Randy.Dunlap" <rdunlap@xenotime.net>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: isa_memcpy_fromio
Date: Sun, 02 Jul 2006 19:37:44 +0200 [thread overview]
Message-ID: <1151861865.3111.23.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <44A7FBBE.9070809@seclark.us>
> Would someone recommend how this should be changed?
>
Hi,
the kernel already has a full DMI decoder, this module appears to just
try to duplicate it (at least judging on the snippet you pasted). It'd
be a lot better if the module would just use the existing DMI layer...
If it did that then it doesn't need isa_memcpy_fromio() *at all*...
see the drivers/firmware/dmi_scan.c file for the linux DMI layer code.
Greetings,
Arjan van de Ven
next prev parent reply other threads:[~2006-07-02 17:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-02 2:43 isa_memcpy_fromio Stephen Clark
2006-07-02 3:42 ` isa_memcpy_fromio Randy.Dunlap
2006-07-02 10:04 ` isa_memcpy_fromio Alan Cox
2006-07-02 16:07 ` isa_memcpy_fromio Randy.Dunlap
2006-07-02 17:00 ` isa_memcpy_fromio Stephen Clark
2006-07-02 17:37 ` Arjan van de Ven [this message]
2006-07-02 18:13 ` isa_memcpy_fromio Stephen Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151861865.3111.23.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=Stephen.Clark@seclark.us \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®