From: Thomas Gleixner <tglx@linutronix.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Ingo Molnar <mingo@elte.hu>,
Russell King <rmk+lkml@arm.linux.org.uk>
Subject: [PATCH] genirq: Fixup ARM devel merge
Date: Mon, 03 Jul 2006 02:22:22 +0200 [thread overview]
Message-ID: <1151886142.24611.34.camel@localhost.localdomain> (raw)
ARM devel merge introduced new machine functionality which was not
covered by the ARM -> genirq patches. Fix it up and make it compile
again.
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Index: linux-2.6.git/arch/arm/plat-omap/gpio.c
===================================================================
--- linux-2.6.git.orig/arch/arm/plat-omap/gpio.c 2006-07-03
00:13:24.000000000 +0200
+++ linux-2.6.git/arch/arm/plat-omap/gpio.c 2006-07-03
01:51:27.000000000 +0200
@@ -850,7 +850,8 @@ static void gpio_irq_handler(unsigned in
/* Don't run the handler if it's already running
* or was disabled lazely.
*/
- if (unlikely((d->disable_depth || d->running))) {
+ if (unlikely((d->depth ||
+ (d->status & IRQ_INPROGRESS)))) {
irq_mask = 1 <<
(gpio_irq - bank->virtual_irq_start);
/* The unmasking will be done by
@@ -859,22 +860,22 @@ static void gpio_irq_handler(unsigned in
* it's already running.
*/
_enable_gpio_irqbank(bank, irq_mask, 0);
- if (!d->disable_depth) {
+ if (!d->depth) {
/* Level triggered interrupts
* won't ever be reentered
*/
BUG_ON(level_mask & irq_mask);
- d->pending = 1;
+ d->status |= IRQ_PENDING;
}
continue;
}
- d->running = 1;
+
desc_handle_irq(gpio_irq, d, regs);
- d->running = 0;
- if (unlikely(d->pending && !d->disable_depth)) {
+
+ if (unlikely((d->status & IRQ_PENDING) && !d->depth)) {
irq_mask = 1 <<
(gpio_irq - bank->virtual_irq_start);
- d->pending = 0;
+ d->status &= ~IRQ_PENDING;
_enable_gpio_irqbank(bank, irq_mask, 1);
retrigger |= irq_mask;
}
reply other threads:[~2006-07-03 0:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1151886142.24611.34.camel@localhost.localdomain \
--to=tglx@linutronix.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®