From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756134AbcEaUgp (ORCPT ); Tue, 31 May 2016 16:36:45 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44201 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750813AbcEaUgo (ORCPT ); Tue, 31 May 2016 16:36:44 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1463741639-5589-1-git-send-email-zyan@redhat.com> References: <1463741639-5589-1-git-send-email-zyan@redhat.com> To: "Yan, Zheng" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-cachefs@redhat.com Subject: Re: [PATCH] FS-Cache: make check_consistency callback return int MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <11519.1464727002.1@warthog.procyon.org.uk> Date: Tue, 31 May 2016 21:36:42 +0100 Message-ID: <11520.1464727002@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Tue, 31 May 2016 20:36:43 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yan, Zheng wrote: > __fscache_check_consistency() calls check_consistency() callback > and return the callback's return value. But the return type of > check_consistency() is bool. So __fscache_check_consistency() > return 1 if the cache is inconsistent. This is inconsistent with > the document. Acked-by: David Howells