From: Arjan van de Ven <arjan@infradead.org>
To: Karsten Keil <kkeil@suse.de>
Cc: greg@kroah.com, Andrew Morton <akpm@osdl.org>,
Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] hisax fix usage of __init*
Date: Wed, 05 Jul 2006 13:37:38 +0200 [thread overview]
Message-ID: <1152099459.3201.19.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20060705112357.GA7003@pingi.kke.suse.de>
On Wed, 2006-07-05 at 13:23 +0200, Karsten Keil wrote:
> diff --git a/drivers/isdn/hisax/config.c b/drivers/isdn/hisax/config.c
> index 5333be5..e103503 100644
> --- a/drivers/isdn/hisax/config.c
> +++ b/drivers/isdn/hisax/config.c
> @@ -1875,7 +1875,7 @@ static void EChannel_proc_rcv(struct his
> #ifdef CONFIG_PCI
> #include <linux/pci.h>
>
> -static struct pci_device_id hisax_pci_tbl[] __initdata = {
> +static struct pci_device_id hisax_pci_tbl[] __devinitdata = {
> #ifdef CONFIG_HISAX_FRITZPCI
> {PCI_VENDOR_ID_AVM, PCI_DEVICE_ID_AVM_A1,
> PCI_ANY_ID, PCI_ANY_ID},
> #endif
> diff --git a/drivers
I think this bit is still buggy; afaik pci_device_id tables should not
be of any kind of __init at all... CC'ing Greg just to make sure I'm not
talking rubbish
Greetings,
Arjan van de Ven
next prev parent reply other threads:[~2006-07-05 11:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-05 11:23 Karsten Keil
2006-07-05 11:37 ` Arjan van de Ven [this message]
2006-07-05 15:08 ` Takashi Iwai
2006-07-06 19:11 ` Greg KH
2006-07-06 19:22 ` Andrew Morton
2006-07-06 19:38 ` Greg KH
2006-07-06 20:22 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1152099459.3201.19.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=kkeil@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®