mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Woodhouse <dwmw2@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@osdl.org, akpm@osdl.org, bernds_cb1@t-online.de,
	sam@ravnborg.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/6] FDPIC: Fix FDPIC compile errors [try #3]
Date: Thu, 06 Jul 2006 14:40:17 +0100	[thread overview]
Message-ID: <1152193217.2987.182.camel@pmac.infradead.org> (raw)
In-Reply-To: <20060706124719.7098.73359.stgit@warthog.cambridge.redhat.com>

On Thu, 2006-07-06 at 13:47 +0100, David Howells wrote:
> From: David Howells <dhowells@redhat.com>
> 
> The attached patch fixes FDPIC compile errors
> 
> Signed-Off-By: David Howells <dhowells@redhat.com>
> ---
> 
>  fs/binfmt_elf_fdpic.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/binfmt_elf_fdpic.c b/fs/binfmt_elf_fdpic.c
> index eba4e23..07624b9 100644
> --- a/fs/binfmt_elf_fdpic.c
> +++ b/fs/binfmt_elf_fdpic.c
> @@ -459,6 +459,7 @@ #endif
>  	 */
>  	hwcap = ELF_HWCAP;
>  	k_platform = ELF_PLATFORM;
> +	u_platform = NULL;
>  
>  	if (k_platform) {
>  		platform_len = strlen(k_platform) + 1;

Isn't this just working around a compiler problem -- a spurious warning?
It certainly shouldn't be a 'compile error',

-- 
dwmw2


  reply	other threads:[~2006-07-06 13:40 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-06 12:47 [PATCH 0/6] Fix FRV, ELF-FDPIC and NOMMU stuff " David Howells
2006-07-06 12:47 ` [PATCH 1/6] FDPIC: Fix FDPIC compile errors " David Howells
2006-07-06 13:40   ` David Woodhouse [this message]
2006-07-07  9:41   ` David Howells
2006-07-06 12:47 ` [PATCH 2/6] FRV: Fix FRV arch " David Howells
2006-07-06 17:31   ` Andrew Morton
2006-07-06 17:36   ` Andrew Morton
2006-07-06 18:25   ` David Howells
2006-07-06 18:39     ` Andrew Morton
2006-07-06 19:02     ` David Howells
2006-07-06 18:29   ` David Howells
2006-07-06 12:47 ` [PATCH 3/6] NOMMU: Fix execution off of ramfs with mmap() " David Howells
2006-07-06 12:47 ` [PATCH 4/6] FDPIC: Adjust the ELF-FDPIC driver to conform more to the CodingStyle " David Howells
2006-07-06 12:47 ` [PATCH 5/6] FDPIC: Add coredump capability for the ELF-FDPIC binfmt " David Howells
2006-07-06 17:52   ` Andrew Morton
2006-07-06 18:38   ` David Howells
2006-07-06 23:27     ` Andrew Morton
2006-07-07  9:46     ` David Howells
2006-07-07 10:54     ` David Howells
2006-07-07 11:00     ` David Howells
2006-07-07 11:12       ` Andrew Morton
2006-07-07  9:54   ` David Howells
2006-07-07 10:20     ` Andrew Morton
2006-07-07 10:34     ` David Howells
2006-07-06 12:47 ` [PATCH 6/6] FRV: Introduce asm-offsets for FRV arch " David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1152193217.2987.182.camel@pmac.infradead.org \
    --to=dwmw2@infradead.org \
    --cc=akpm@osdl.org \
    --cc=bernds_cb1@t-online.de \
    --cc=dhowells@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®