From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161020AbWGIPBx (ORCPT ); Sun, 9 Jul 2006 11:01:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161021AbWGIPBx (ORCPT ); Sun, 9 Jul 2006 11:01:53 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:64130 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1161020AbWGIPBw (ORCPT ); Sun, 9 Jul 2006 11:01:52 -0400 Subject: Re: [RFC][PATCH 1/2] firmware version management: add firmware_version() From: Arjan van de Ven To: Martin Langer Cc: Marcel Holtmann , linux-kernel@vger.kernel.org, bcm43xx-dev@lists.berlios.de In-Reply-To: <20060709122118.GA3678@tuba> References: <20060708130904.GA3819@tuba> <1152365514.3120.46.camel@laptopd505.fenrus.org> <1152366597.29506.13.camel@localhost> <20060709122118.GA3678@tuba> Content-Type: text/plain Date: Sun, 09 Jul 2006 17:01:49 +0200 Message-Id: <1152457310.3255.58.camel@laptopd505.fenrus.org> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2006-07-09 at 14:21 +0200, Martin Langer wrote: > On Sat, Jul 08, 2006 at 03:49:57PM +0200, Marcel Holtmann wrote: > > Hi Arjan, > > > > > > It would be good if a driver knows which firmware version will be > > > > written to the hardware. I'm talking about external firmware files > > > > claimed by request_firmware(). > > > > > > > > We know so many different firmware files for bcm43xx and it becomes > > > > more and more complicated without some firmware version management. > > > > > > > > This patch can create the md5sum of a firmware file. Then it looks into > > > > a table to figure out which version number is assigned to the hashcode. > > > > That table is placed in the driver code and an example for bcm43xx comes > > > > in my next mail. Any comments? > > > > > > why does this have to happen on the kernel side? Isn't it a lot easier > > > and better to let the userspace side of things do this work, and even > > > have a userspace file with the md5->version mapping? Or are there some > > > practical considerations that make that hard to impossible? > > > > I fully agree that we shouldn't put firmware versioning into the kernel > > drivers. The pattern you give to request_firmware() can be mapped to any > > file on the file system. And you also have the link to the device object > > and I prefer you export a sysfs file for the version so that the helper > > application loading the firmware can pick the right file. > > Bcm43xx has no helper application to upload the firmware. yes it does. bcm43xx asks userspace to upload firmware (via request_firmware() ) and a userspace app (udev most of the time) will upload it. That app, eg udev, can do the md5sum and checking it against a list of "known good" firmwares. Voila problem solved ;)