From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030406AbWGJOTv (ORCPT ); Mon, 10 Jul 2006 10:19:51 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030428AbWGJOTu (ORCPT ); Mon, 10 Jul 2006 10:19:50 -0400 Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:41166 "EHLO lxorguk.ukuu.org.uk") by vger.kernel.org with ESMTP id S1030431AbWGJOTu (ORCPT ); Mon, 10 Jul 2006 10:19:50 -0400 Subject: Re: [PATCH] Clean up old names in tty code to current names From: Alan Cox To: Jon Smirl Cc: "H. Peter Anvin" , Greg KH , lkml , Andrew Morton In-Reply-To: <9e4733910607100707g4810a86boa93a5b6b0b1a8d0a@mail.gmail.com> References: <9e4733910607092111i4c41c610u8b9df5b917cca02c@mail.gmail.com> <1152524657.27368.108.camel@localhost.localdomain> <9e4733910607100541i744dd744n16c35c50dae1e98d@mail.gmail.com> <1152537049.27368.119.camel@localhost.localdomain> <9e4733910607100603r5ae1a21ex1a2fa0f045424fd1@mail.gmail.com> <1152539034.27368.124.camel@localhost.localdomain> <9e4733910607100707g4810a86boa93a5b6b0b1a8d0a@mail.gmail.com> Content-Type: text/plain Content-Transfer-Encoding: 7bit Date: Mon, 10 Jul 2006 15:37:29 +0100 Message-Id: <1152542249.27368.128.camel@localhost.localdomain> Mime-Version: 1.0 X-Mailer: Evolution 2.6.2 (2.6.2-1.fc5.5) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Ar Llu, 2006-07-10 am 10:07 -0400, ysgrifennodd Jon Smirl: > The ttyp change was a mistake. The patch below removes that error. Is > there anything else wrong with it? That's why we have patch reviews, > to catch dumb errors like that. Its change for no purpose. It doesn't "fix" anything and it might well break stuff like installers. Put the new "correct" data in the new sysfs stuff you talk about. Alan