From: Arjan van de Ven <arjan@infradead.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Dave Jones <davej@redhat.com>,
mingo@redhat.com, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: lockdep input layer warnings.
Date: Mon, 10 Jul 2006 17:53:32 +0200 [thread overview]
Message-ID: <1152546812.4874.69.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <d120d5000607100849k5af2ee78o2715d9a51b06c000@mail.gmail.com>
On Mon, 2006-07-10 at 11:49 -0400, Dmitry Torokhov wrote:
> On 7/10/06, Arjan van de Ven <arjan@infradead.org> wrote:
> > On Thu, 2006-07-06 at 16:29 -0400, Dmitry Torokhov wrote:
> > >
> > > Well, you are right, the patch is in -rc1 and I see mutex_lock_nested
> > > in the backtrace but for some reason it is still not happy. Again,
> > > this is with pass-through Synaptics port and we first taking mutex of
> > > the child device and then (going through pass-through port) trying to
> > > take mutex of the parent.
> >
> > Ok it seems more drastic measures are needed; and a split of the
> > cmd_mutex class on a per driver basis. The easiest way to do that is to
> > inline the lock initialization (patch below) but to be honest I think
> > the patch is a bit ugly; I considered inlining the entire function
> > instead, any opinions on that?
> >
>
> It is ugly. Maybe we could have something like mutex_init_nolockdep()
> to annotate that lockdep is confused and make it ignore such locks?
nope but there is a function to make it unique, we could put that in the
wrapper instead of mutex_init if that makes it less ugly..
next prev parent reply other threads:[~2006-07-10 15:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-06 17:34 Dave Jones
2006-07-06 18:37 ` Dmitry Torokhov
2006-07-06 19:02 ` Arjan van de Ven
2006-07-06 20:29 ` Dmitry Torokhov
2006-07-10 15:12 ` Arjan van de Ven
2006-07-10 15:49 ` Dmitry Torokhov
2006-07-10 15:53 ` Arjan van de Ven [this message]
2006-07-10 15:59 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1152546812.4874.69.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=davej@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®