From: Kylene Jo Hall <kjhall@us.ibm.com>
To: linux-kernel <linux-kernel@vger.kernel.org>
Cc: TPM Device Driver List <tpmdd-devel@lists.sourceforge.net>,
akpm@osdl.org
Subject: [PATCH] tpm: interrupt clear fix
Date: Wed, 12 Jul 2006 14:01:53 -0700 [thread overview]
Message-ID: <1152738113.5347.33.camel@localhost.localdomain> (raw)
Under stress testing I found that the interrupt is not always cleared.
This is a bug and this patch should go into 2.6.18 and 2.6.17.x.
Signed-off-by: Kylene Hall <kjhall@us.ibm.com>
---
--- tcg/tpmdd/drivers/char/tpm/tpm_tis.c 2006-06-07 11:37:08.000000000 -0700
+++ linux-2.6.17/drivers/char/tpm/tpm_tis.c 2006-07-10 12:58:28.000000000 -0700
@@ -424,6 +424,7 @@ static irqreturn_t tis_int_handler(int i
iowrite32(interrupt,
chip->vendor.iobase +
TPM_INT_STATUS(chip->vendor.locality));
+ mb();
return IRQ_HANDLED;
}
next reply other threads:[~2006-07-12 21:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-12 21:01 Kylene Jo Hall [this message]
2006-07-12 22:04 ` Alan Cox
2006-07-13 11:45 ` linux-os (Dick Johnson)
2006-07-13 19:24 ` Kylene Jo Hall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1152738113.5347.33.camel@localhost.localdomain \
--to=kjhall@us.ibm.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tpmdd-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome