From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Greg KH <greg@kroah.com>
Cc: Pierre Ossman <drzeus-list@drzeus.cx>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: resource_size_t and printk()
Date: Wed, 12 Jul 2006 23:08:26 +0100 [thread overview]
Message-ID: <1152742106.22943.108.camel@localhost.localdomain> (raw)
In-Reply-To: <20060712213723.GB9049@kroah.com>
Ar Mer, 2006-07-12 am 14:37 -0700, ysgrifennodd Greg KH:
> Like Randy said, please use "unsigned long long".
>
> Care to redo this?
While you are at it someone did 8139cp and used "%l" not "%ll"
Signed-off-by: Alan Cox <alan@redhat.com>
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.18-rc1/drivers/net/8139cp.c linux-2.6.18-rc1/drivers/net/8139cp.c
--- linux.vanilla-2.6.18-rc1/drivers/net/8139cp.c 2006-07-12 12:16:46.000000000 +0100
+++ linux-2.6.18-rc1/drivers/net/8139cp.c 2006-07-12 12:47:20.000000000 +0100
@@ -1916,7 +1916,7 @@
regs = ioremap(pciaddr, CP_REGS_SIZE);
if (!regs) {
rc = -EIO;
- dev_err(&pdev->dev, "Cannot map PCI MMIO (%lx@%lx)\n",
+ dev_err(&pdev->dev, "Cannot map PCI MMIO (%llx@%llx)\n",
(unsigned long long)pci_resource_len(pdev, 1),
(unsigned long long)pciaddr);
goto err_out_res;
next prev parent reply other threads:[~2006-07-12 21:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-04 20:54 Pierre Ossman
2006-07-04 21:45 ` Greg KH
2006-07-05 4:20 ` Pierre Ossman
2006-07-11 23:15 ` Greg KH
2006-07-12 8:18 ` Pierre Ossman
2006-07-12 15:15 ` Randy.Dunlap
2006-07-12 15:33 ` Kyle McMartin
2006-07-12 21:37 ` Greg KH
2006-07-12 22:08 ` Alan Cox [this message]
2006-07-13 9:35 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1152742106.22943.108.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=drzeus-list@drzeus.cx \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome