From: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>
To: Arjan van de Ven <arjan@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-pci maillist <linux-pci@atrey.karlin.mff.cuni.cz>,
Greg KH <greg@kroah.com>,
Tom Long Nguyen <tom.l.nguyen@intel.com>
Subject: Re: [PATCH 4/5] PCI-Express AER implemetation: AER core and aerdriver
Date: Thu, 13 Jul 2006 10:08:40 +0800 [thread overview]
Message-ID: <1152756520.28493.273.camel@ymzhang-perf.sh.intel.com> (raw)
In-Reply-To: <1152710184.3217.41.camel@laptopd505.fenrus.org>
On Wed, 2006-07-12 at 21:16, Arjan van de Ven wrote:
> > +
> > + struct semaphore rpc_sema; /*
> > + * Semaphore access required to
> > + * access, add, remove, or print AER
> > + * aware devices in this RPC hierarchy
> > + */
>
>
> Hi,
>
> sorry to bug you again..
Any comment is welcome.
> but is there a reason you're introducing a new
> semaphore and not a mutex? From looking at the code it could/should be a
> mutex...
It could be a mutex and be deleted because every root port has its own rpc. workqueue
could guarantee only one keventd will service the work at the same time.
next prev parent reply other threads:[~2006-07-13 2:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-12 7:10 [PATCH 1/5] PCI-Express AER implemetation: aer howto document Zhang, Yanmin
2006-07-12 7:16 ` [PATCH 2/5] PCI-Express AER implemetation: Add new defines to pci_regs.h Zhang, Yanmin
2006-07-12 7:22 ` [PATCH 3/5] PCI-Express AER implemetation: export pcie_port_bus_type Zhang, Yanmin
2006-07-12 7:32 ` [PATCH 4/5] PCI-Express AER implemetation: AER core and aerdriver Zhang, Yanmin
2006-07-12 7:38 ` [PATCH 5/5] PCI-Express AER implemetation: pcie_portdrv error handler Zhang, Yanmin
2006-07-12 8:06 ` [PATCH 4/5] PCI-Express AER implemetation: AER core and aerdriver Zhang, Yanmin
2006-07-12 13:16 ` Arjan van de Ven
2006-07-13 2:08 ` Zhang, Yanmin [this message]
2006-07-12 16:26 ` Andi Kleen
2006-07-13 2:16 ` Zhang, Yanmin
2006-07-12 8:00 ` [PATCH 3/5] PCI-Express AER implemetation: export pcie_port_bus_type Zhang, Yanmin
2006-07-14 5:25 ` [PATCH 1/5] PCI-Express AER implemetation: aer howto document Zhang, Yanmin
2006-07-14 5:27 ` [PATCH 2/5] PCI-Express AER implemetation: Add new defines to pci_regs.h Zhang, Yanmin
2006-07-14 5:28 ` [PATCH 3/5] PCI-Express AER implemetation: export pcie_port_bus_type Zhang, Yanmin
2006-07-14 5:30 ` [PATCH 4/5] PCI-Express AER implemetation: AER core and aerdriver Zhang, Yanmin
2006-07-14 5:32 ` [PATCH 4/5] PCI-Express AER implemetation: pcie_portdrv error handler Zhang, Yanmin
2006-07-14 5:35 ` [PATCH 5/5] " Zhang, Yanmin
2006-07-24 19:37 ` Linas Vepstas
2006-07-26 4:56 ` Zhang, Yanmin
2006-07-14 12:40 ` [PATCH 1/5] PCI-Express AER implemetation: aer howto document Andi Kleen
2006-07-17 1:24 ` Zhang, Yanmin
2006-07-24 20:48 ` Linas Vepstas
2006-07-26 5:48 ` Zhang, Yanmin
2006-07-12 17:21 [PATCH 4/5] PCI-Express AER implemetation: AER core and aerdriver Johnny Lever
2006-07-12 17:32 ` Arjan van de Ven
2006-07-12 18:07 ` Johnny Lever
2006-07-13 8:45 ` Christoph Hellwig
2006-07-13 11:26 ` Johnny Lever
2006-07-31 3:00 [PATCH 1/5] PCI-Express AER implemetation: aer howto document Zhang, Yanmin
2006-07-31 3:10 ` [PATCH 2/5] PCI-Express AER implemetation: Add new defines to pci_regs.h Zhang, Yanmin
2006-07-31 3:14 ` [PATCH 3/5] PCI-Express AER implemetation: export pcie_port_bus_type Zhang, Yanmin
2006-07-31 3:22 ` [PATCH 4/5] PCI-Express AER implemetation: AER core and aerdriver Zhang, Yanmin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1152756520.28493.273.camel@ymzhang-perf.sh.intel.com \
--to=yanmin_zhang@linux.intel.com \
--cc=arjan@infradead.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=tom.l.nguyen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®