From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030315AbWGMT0S (ORCPT ); Thu, 13 Jul 2006 15:26:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030313AbWGMT0S (ORCPT ); Thu, 13 Jul 2006 15:26:18 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:55725 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1030312AbWGMT0R (ORCPT ); Thu, 13 Jul 2006 15:26:17 -0400 Subject: Re: [patch] lockdep: annotate mm/slab.c From: Arjan van de Ven To: Linus Torvalds Cc: Ingo Molnar , Andrew Morton , sekharan@us.ibm.com, linux-kernel@vger.kernel.org, nagar@watson.ibm.com, balbir@in.ibm.com In-Reply-To: References: <1152763195.11343.16.camel@linuxchandra> <20060713071221.GA31349@elte.hu> <20060713002803.cd206d91.akpm@osdl.org> <20060713072635.GA907@elte.hu> <20060713004445.cf7d1d96.akpm@osdl.org> <20060713124603.GB18936@elte.hu> <1152817589.3024.64.camel@laptopd505.fenrus.org> Content-Type: text/plain Date: Thu, 13 Jul 2006 21:26:02 +0200 Message-Id: <1152818768.3024.79.camel@laptopd505.fenrus.org> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-2.fc4) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2006-07-13 at 12:21 -0700, Linus Torvalds wrote: > > On Thu, 13 Jul 2006, Arjan van de Ven wrote: > > > On Thu, 2006-07-13 at 11:50 -0700, Linus Torvalds wrote: > > > > > > Why isn't the "on_slab_key" local to just the init_lock_keys() > > > function, > > > and the #ifdef around it all? > > > > it's the same net results; the variable is 0 bytes in size for !LOCKDEP > > That's not why I reacted. I reacted because the code is ugly, and would be > much cleaner if it had everything in one place. fair enough