From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161157AbWGNAZX (ORCPT ); Thu, 13 Jul 2006 20:25:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161158AbWGNAZW (ORCPT ); Thu, 13 Jul 2006 20:25:22 -0400 Received: from pentafluge.infradead.org ([213.146.154.40]:39838 "EHLO pentafluge.infradead.org") by vger.kernel.org with ESMTP id S1161157AbWGNAZW (ORCPT ); Thu, 13 Jul 2006 20:25:22 -0400 Subject: Re: 2.6.18 Headers - Long From: David Woodhouse To: Jim Gifford Cc: LKML , ralf@linux-mips.org In-Reply-To: <44B443D2.4070600@jg555.com> References: <44B443D2.4070600@jg555.com> Content-Type: text/plain Date: Fri, 14 Jul 2006 01:25:48 +0100 Message-Id: <1152836749.31372.36.camel@shinybook.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.6.2 (2.6.2-1.fc5.6.dwmw2.1) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by pentafluge.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2006-07-11 at 17:35 -0700, Jim Gifford wrote: > I will only document one issue, but there are several more like this > in the kernel. Please elaborate, preferably in 'diff -u' form as below... > I'm going to use the MIPS architecture in my example, along with the > file page.h. [PATCH] Reduce user-visible noise in asm-mips/page.h Since PAGE_SIZE is variable according to configuration options, don't expose it to userspace. Userspace should be using sysconf(_SC_PAGE_SIZE) instead. Move some other noise inside __KERNEL__ too while we're at it. Signed-off-by: David Woodhouse diff --git a/include/asm-mips/page.h b/include/asm-mips/page.h index 6ed1151..ee2ef88 100644 --- a/include/asm-mips/page.h +++ b/include/asm-mips/page.h @@ -14,8 +14,6 @@ #ifdef __KERNEL__ #include -#endif - /* * PAGE_SHIFT determines the page size */ @@ -35,7 +33,6 @@ #define PAGE_SIZE (1UL << PAGE_SHIFT) #define PAGE_MASK (~((1 << PAGE_SHIFT) - 1)) -#ifdef __KERNEL__ #ifndef __ASSEMBLY__ extern void clear_page(void * page); @@ -168,7 +165,6 @@ #define VM_DATA_DEFAULT_FLAGS (VM_READ | #define UNCAC_ADDR(addr) ((addr) - PAGE_OFFSET + UNCAC_BASE) #define CAC_ADDR(addr) ((addr) - UNCAC_BASE + PAGE_OFFSET) -#endif /* defined (__KERNEL__) */ #ifdef CONFIG_LIMITED_DMA #define WANT_PAGE_VIRTUAL @@ -177,4 +173,6 @@ #endif #include #include +#endif /* defined (__KERNEL__) */ + #endif /* _ASM_PAGE_H */ -- dwmw2