Re: [v4l-dvb-maintainer] Re: [PATCH] V4L: struct video_device corruption

[Mauro Carvalho Chehab <mchehab@infradead.org>]

Ok, I had some time to fix the broken dependencies. Please look at the
two commits I did today.

One patch removes HAVE_V4L1 check at drivers. It also include some
checks for V4L1_COMPAT on some core files that should implement both
calls to provide support for V4L1 drivers.

The other fixes the broken dependencies for drivers that still need V4L1
to work properly.

Cheers,
Mauro.

Em Sex, 2006-07-21 às 15:55 -0700, Trent Piepho escreveu:
> On Fri, 21 Jul 2006, Mauro Carvalho Chehab wrote:
> > config VIDEO_BT848
> >         tristate "BT848 Video For Linux"
> >         depends on VIDEO_DEV && PCI && I2C && VIDEO_V4L2
> >
> > Argh! it should be V4L1 instead!
> 
> You can compile and use bt848 without V4L1 turned on.  It still has some
> V4L1 functions defined.
> 
> > > All these files include v4l2-dev.h and have HAVE_V4L1 defined when V4L1 is
> > > not turned on in Kconfig.  There files are all buildable when V4L1 is off;
> > > they don't depend on it in Kconfig.
> > Some of the above drivers are V4L2, like tda9887, tuner-core,
> > tuner-simple, msp3400, cs53l32a, tveeprom, wm87xx. Maybe they are just
> > including the wrong headers. We should try to change to videodev2.h and
> > see what happens with all those drivers. The ones that break should me
> > marked with the proper requirement on Kconfig.
> >
> > Some of they need some #ifdef inside. For example, compat_ioctl32 should
> > handle both APIs, since it is a generic code to fix 32 bit calls to 64
> > bit kernel.
> 
> I think this is pretty much what I've been saying.  Drivers should:
> A. Not include videodev.h, but use videodev2.h
> B. Include videodev.h, but be marked V4L1 in Kconfig
> C. #ifdef around videodev.h (and code that needs videodev.h), so it
>    is not included or needed when V4L1 is turned off.
Cheers, 
Mauro.