From: Josh Triplett <josht@us.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@osdl.org>, Jan Harkes <jaharkes@cs.cmu.edu>,
coda@cs.cmu.edu, codalist@TELEMANN.coda.cs.cmu.edu
Subject: [PATCH] [coda] Remove incorrect unlock_kernel from allocation failure path in coda_open
Date: Mon, 24 Jul 2006 14:23:58 -0700 [thread overview]
Message-ID: <1153776238.4931.11.camel@josh-work.beaverton.ibm.com> (raw)
Commit 398c53a757702e1e3a7a2c24860c7ad26acb53ed (in the historical GIT tree)
moved the lock_kernel() in coda_open after the allocation of a coda_file_info
struct, but left an unlock_kernel() in the allocation failure error path;
remove it.
Signed-off-by: Josh Triplett <josh@freedesktop.org>
---
fs/coda/file.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/fs/coda/file.c b/fs/coda/file.c
index cc66c68..dbfbcfa 100644
--- a/fs/coda/file.c
+++ b/fs/coda/file.c
@@ -136,10 +136,8 @@ int coda_open(struct inode *coda_inode,
coda_vfs_stat.open++;
cfi = kmalloc(sizeof(struct coda_file_info), GFP_KERNEL);
- if (!cfi) {
- unlock_kernel();
+ if (!cfi)
return -ENOMEM;
- }
lock_kernel();
next reply other threads:[~2006-07-24 21:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-24 21:23 Josh Triplett [this message]
2006-07-25 0:08 ` Jan Harkes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1153776238.4931.11.camel@josh-work.beaverton.ibm.com \
--to=josht@us.ibm.com \
--cc=akpm@osdl.org \
--cc=coda@cs.cmu.edu \
--cc=codalist@TELEMANN.coda.cs.cmu.edu \
--cc=jaharkes@cs.cmu.edu \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®