From: Rusty Russell <rusty@rustcorp.com.au>
To: Peter Chubb <peter@chubb.wattle.id.au>
Cc: Chuck Ebbert <76306.1226@compuserve.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@muc.de>
Subject: Re: [PATCH 5/6] Begin abstraction of sensitive instructions: asm files
Date: Wed, 26 Jul 2006 13:25:47 +1000 [thread overview]
Message-ID: <1153884349.5500.55.camel@localhost.localdomain> (raw)
In-Reply-To: <873bcp6y3s.wl%peter@chubb.wattle.id.au>
On Wed, 2006-07-26 at 09:52 +1000, Peter Chubb wrote:
> >>>>> "Rusty" == Rusty Russell <rusty@rustcorp.com.au> writes:
>
> Rusty> Agreed: certainly eax should be mentioned. GET_CR0_INTO_EAX?
> Rusty> MOV is a bit close to describing how it's happening (which, on
> Rusty> paravirt it might not be) so it might lead the reader to
> Rusty> unwarranted assumptions.
>
> Aren't these ideal cases to use a tool to convert, rather than adding
> manual changes to the source? The `afterburner' approach works quite
> well for this kind of thing.
Agreed, afterburner works well in that it's minimally invasive in the
source. However, that is precisely the opposite of the aim of patches
like this one which are integrated: that the source code be explicit.
Cheers,
Rusty.
--
Help! Save Australia from the worst of the DMCA: http://linux.org.au/law
next prev parent reply other threads:[~2006-07-26 3:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-22 3:23 Chuck Ebbert
2006-07-22 13:34 ` Rusty Russell
2006-07-24 17:36 ` Andi Kleen
2006-07-24 20:54 ` Jeremy Fitzhardinge
2006-07-25 23:52 ` Peter Chubb
2006-07-26 3:25 ` Rusty Russell [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-07-22 0:14 Rusty Russell
2006-07-30 10:52 ` Pavel Machek
2006-07-30 10:56 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1153884349.5500.55.camel@localhost.localdomain \
--to=rusty@rustcorp.com.au \
--cc=76306.1226@compuserve.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@chubb.wattle.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome