From: Arjan van de Ven <arjan@infradead.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: Josh Triplett <josht@us.ibm.com>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
nfs@lists.sourceforge.net, Neil Brown <neilb@cse.unsw.edu.au>
Subject: Re: [NFS] [PATCH] [nfsd] Add lock annotations to e_start and e_stop
Date: Wed, 26 Jul 2006 10:19:35 +0200 [thread overview]
Message-ID: <1153901976.3381.1.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20060726080656.GA28346@infradead.org>
On Wed, 2006-07-26 at 09:06 +0100, Christoph Hellwig wrote:
> On Tue, Jul 25, 2006 at 08:20:24AM -0700, Josh Triplett wrote:
> > e_start acquires svc_export_cache.hash_lock, and e_stop releases it. Add lock
> > annotations to these two functions so that sparse can check callers for lock
> > pairing, and so that sparse will not complain about these functions since they
> > intentionally use locks in this manner.
> >
> > Signed-off-by: Josh Triplett <josh@freedesktop.org>
>
> The Signed-off-by: line doesn't match the from line of this mail. Is that
> any problem or fine in general?
As far as I can see it's customary for the SOB line to state the
affiliation of the person, eg the company that wants to own the
copyright on the code. So I'd expect Josh to use his ibm.com account...
Greetings,
Arjan van de Ven
--
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
next prev parent reply other threads:[~2006-07-26 8:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-25 15:20 Josh Triplett
2006-07-26 8:06 ` [NFS] " Christoph Hellwig
2006-07-26 8:19 ` Arjan van de Ven [this message]
2006-07-26 15:42 ` Josh Triplett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1153901976.3381.1.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=josht@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@cse.unsw.edu.au \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®