From: Jacob Keller <jacob.e.keller@intel.com>
To: Alok Tiwari <alok.a.tiwari@oracle.com>,
<anthony.l.nguyen@intel.com>, <przemyslaw.kitszel@intel.com>,
<andrew+netdev@lunn.ch>, <davem@davemloft.net>,
<edumazet@google.com>, <kuba@kernel.org>, <pabeni@redhat.com>,
<intel-wired-lan@lists.osuosl.org>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<darren.kenny@oracle.com>
Subject: Re: [PATCH] ixgbe: Fix typos and clarify comments in X550 driver code
Date: Thu, 22 May 2025 13:53:12 -0700 [thread overview]
Message-ID: <1153fdf3-581e-4c35-a24a-55534e1e9a5b@intel.com> (raw)
In-Reply-To: <20250522074734.3634633-1-alok.a.tiwari@oracle.com>
On 5/22/2025 12:47 AM, Alok Tiwari wrote:
> Corrected spelling errors such as "simular" -> "similar",
> "excepted" -> "accepted", and "Determime" -> "Determine".
> Fixed including incorrect word usage ("to MAC" -> "two MAC")
> and improved awkward phrasing.
>
> Aligned function header descriptions with their actual functionality
> (e.g., "Writes a value" -> "Reads a value").
> Corrected typo in error code from -ENIVAL to -EINVAL.
> Improved overall clarity and consistency in comment across various
> functions.
>
> These changes improve maintainability and readability of the code
> without affecting functionality.
>
> Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
> ---
With or without the s/accepted/expected/ suggestion from Simon:
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
prev parent reply other threads:[~2025-05-22 20:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 7:47 Alok Tiwari
2025-05-22 17:21 ` Simon Horman
2025-05-22 18:11 ` [External] : " ALOK TIWARI
2025-05-23 7:19 ` Simon Horman
2025-05-22 20:53 ` Jacob Keller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1153fdf3-581e-4c35-a24a-55534e1e9a5b@intel.com \
--to=jacob.e.keller@intel.com \
--cc=alok.a.tiwari@oracle.com \
--cc=andrew+netdev@lunn.ch \
--cc=anthony.l.nguyen@intel.com \
--cc=darren.kenny@oracle.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®