From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>, Pavel Machek <pavel@ucw.cz>,
Vojtech Pavlik <vojtech@suse.cz>, Jason Lunz <lunz@falooley.org>
Subject: Re: [PATCH] amd74xx: implement suspend-to-ram
Date: Fri, 28 Jul 2006 17:51:55 +0100 [thread overview]
Message-ID: <1154105517.13509.153.camel@localhost.localdomain> (raw)
In-Reply-To: <200607281646.31207.rjw@sisk.pl>
Ar Gwe, 2006-07-28 am 16:46 +0200, ysgrifennodd Rafael J. Wysocki:
> From: Jason Lunz <lunz@falooley.org>
>
> The amd74xx driver needs to reprogram each drive's PIO timings as well
> as the DMA timings on resume from s2ram. Otherwise, my
> nforce3-150-based laptop hangs hard when ide_start_power_step() calls
> drive->hwif->ide_dma_check(drive).
NAK
This beings in the IDE power step code. You should do that as a step
before the win_idleimmediate I suspect. Theory is right, diagnosis is
right, implementation is in the wrong place.
You'll make a lot more people happy by fixing it in ide-io
Alan
next prev parent reply other threads:[~2006-07-28 16:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-28 14:46 Rafael J. Wysocki
2006-07-28 16:51 ` Alan Cox [this message]
2006-07-28 17:13 ` Jason Lunz
2006-07-28 19:16 ` Brad Campbell
2006-07-28 20:00 ` Alan Cox
2006-08-01 7:18 ` Benjamin Herrenschmidt
2006-07-29 23:34 ` [patch, rft] ide: reprogram disk pio timings on resume Jason Lunz
2006-07-30 3:25 ` Brad Campbell
2006-07-30 17:26 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1154105517.13509.153.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lunz@falooley.org \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome