mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Haavard Skinnemoen <hskinnemoen@atmel.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
	Haavard Skinnemoen <hskinnemoen@atmel.com>
Subject: [PATCH 2/14] Generic ioremap_page_range: flush_cache_vmap
Date: Thu, 10 Aug 2006 18:03:34 +0200	[thread overview]
Message-ID: <11552258271630-git-send-email-hskinnemoen@atmel.com> (raw)
In-Reply-To: <1155225827754-git-send-email-hskinnemoen@atmel.com>

The existing implementation of ioremap_page_range(), which was taken
from i386, does this:

	flush_cache_all();
	/* modify page tables */
	flush_tlb_all();

I think this is a bit defensive, so this patch changes the generic
implementation to do:

	/* modify page tables */
	flush_cache_vmap(start, end);

instead, which is similar to what vmalloc() does. This should still
be correct because we never modify existing PTEs. According to
James Bottomley:

The problem the flush_tlb_all() is trying to solve is to avoid stale tlb
entries in the ioremap area.  We're just being conservative by flushing
on both map and unmap.  Technically what vmalloc/vfree does (only flush
the tlb on unmap) is just fine because it means that the only tlb
entries in the remap area must belong to in-use mappings.

Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
---
 lib/ioremap.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/lib/ioremap.c b/lib/ioremap.c
index 6419101..d2cb1eb 100644
--- a/lib/ioremap.c
+++ b/lib/ioremap.c
@@ -75,8 +75,6 @@ int ioremap_page_range(unsigned long add
 
 	BUG_ON(addr >= end);
 
-	flush_cache_all();
-
 	start = addr;
 	phys_addr -= addr;
 	pgd = pgd_offset_k(addr);
@@ -87,7 +85,7 @@ int ioremap_page_range(unsigned long add
 			break;
 	} while (pgd++, addr = next, addr != end);
 
-	flush_tlb_all();
+	flush_cache_vmap(start, end);
 
 	return err;
 }
-- 
1.4.0


  reply	other threads:[~2006-08-10 16:04 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-10 16:03 [PATCH 0/14] Generic ioremap_page_range: introduction Haavard Skinnemoen
2006-08-10 16:03 ` [PATCH 1/14] Generic ioremap_page_range: implementation Haavard Skinnemoen
2006-08-10 16:03   ` Haavard Skinnemoen [this message]
2006-08-10 16:03     ` [PATCH 3/14] Generic ioremap_page_range: alpha conversion Haavard Skinnemoen
2006-08-10 16:03       ` [PATCH 4/14] Generic ioremap_page_range: arm conversion Haavard Skinnemoen
2006-08-10 16:03         ` [PATCH 5/14] Generic ioremap_page_range: avr32 conversion Haavard Skinnemoen
2006-08-10 16:03           ` [PATCH 6/14] Generic ioremap_page_range: cris conversion Haavard Skinnemoen
2006-08-10 16:03             ` [PATCH 7/14] Generic ioremap_page_range: i386 conversion Haavard Skinnemoen
2006-08-10 16:03               ` [PATCH 8/14] Generic ioremap_page_range: m32r conversion Haavard Skinnemoen
2006-08-10 16:03                 ` [PATCH 9/14] Generic ioremap_page_range: mips conversion Haavard Skinnemoen
2006-08-10 16:03                   ` [PATCH 10/14] Generic ioremap_page_range: parisc conversion Haavard Skinnemoen
2006-08-10 16:03                     ` [PATCH 11/14] Generic ioremap_page_range: s390 conversion Haavard Skinnemoen
2006-08-10 16:03                       ` [PATCH 12/14] Generic ioremap_page_range: sh conversion Haavard Skinnemoen
2006-08-10 16:03                         ` [PATCH 13/14] Generic ioremap_page_range: sh64 conversion Haavard Skinnemoen
2006-08-10 16:03                           ` [PATCH 14/14] Generic ioremap_page_range: x86_64 conversion Haavard Skinnemoen
2006-08-10 16:54                             ` Andi Kleen
2006-08-10 16:53               ` [PATCH 7/14] Generic ioremap_page_range: i386 conversion Andi Kleen
2006-08-10 17:39                 ` Håvard Skinnemoen
2006-08-14  7:19         ` [PATCH 4/14] Generic ioremap_page_range: arm conversion Russell King
2006-08-10 16:09       ` [PATCH 3/14] Generic ioremap_page_range: alpha conversion Haavard Skinnemoen
2006-08-10 18:42 ` [PATCH 0/14] Generic ioremap_page_range: introduction Håvard Skinnemoen
2006-08-10 18:51   ` Andrew Morton
2006-08-10 18:56     ` Haavard Skinnemoen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11552258271630-git-send-email-hskinnemoen@atmel.com \
    --to=hskinnemoen@atmel.com \
    --cc=akpm@osdl.org \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®