From: James Bottomley <James.Bottomley@SteelEye.com>
To: Seokmann Ju <sju@lsil.com>
Cc: Andrew Morton <akpm@osdl.org>,
ebiederm@xmission.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] scsi : megaraid_{mm, mbox} : irq data type fix
Date: Thu, 10 Aug 2006 12:32:51 -0500 [thread overview]
Message-ID: <1155231171.3670.32.camel@mulgrave.il.steeleye.com> (raw)
In-Reply-To: <1155228887.6698.7.camel@dhcp-65-957.se.lsil.com>
On Thu, 2006-08-10 at 12:54 -0400, Seokmann Ju wrote:
> This patch fixes incorrect irq data type in the driver which led driver initialization failure in some cases.
> The problem was reported by Eric @. Biederman <ebiederm@xmission.com>.
[...]
> uint32_t unique_id;
> - uint8_t irq;
> + unsigned int irq;
> uint8_t ito;
This doesn't look right ... you're altering the size of a packed field
within the ioctl body. This will break the ioctl ABI (and thus all
tools which use it) unless you employ versioning or some other mechanism
to detect the breakage and compensate. I really don't think you want to
do this.
James
next prev parent reply other threads:[~2006-08-10 17:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-10 16:54 Seokmann Ju
2006-08-10 17:32 ` James Bottomley [this message]
2006-08-10 17:34 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1155231171.3670.32.camel@mulgrave.il.steeleye.com \
--to=james.bottomley@steeleye.com \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sju@lsil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®