mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: Ron Yorston <rmy@tigress.co.uk>
Cc: Val Henson <val.henson@gmail.com>,
	akpm@osdl.org, linux-kernel@vger.kernel.org,
	linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] ext2: avoid needless discard of preallocated blocks
Date: Sun, 20 Aug 2006 17:24:59 +0200	[thread overview]
Message-ID: <1156087499.23756.39.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <200608201148.k7KBm8XA005948@tiffany.internal.tigress.co.uk>

On Sun, 2006-08-20 at 12:48 +0100, Ron Yorston wrote:
> Andrew Morton <akpm@osdl.org> wrote:
> >Been there, done that.  The problem was that hanging onto the preallocation
> >will cause separate files to have up-to-seven-block gaps between them.  So
> >if you put a large number of small files in the same directory, the time to
> >read them all back is quite significantly impacted: they cover a lot more
> >disk.
> 
> The preallocation is only held while the file is open, so there will only
> be gaps between files that are open simultaneously.  If they're created
> sequentially there will be no gap.
> 
> This issue exists even with the current code.
> 
> The patch will have a small effect.  With the current code an open file
> will lose its preallocation when some other process touches the inode.
> In that case a subsequently created file will follow without a gap.  As
> soon as the open file is written to, though, it gets a new preallocation.
> -

maybe porting the reservation code to ext2 (as Val has done) is a nicer
long term solution..

-- 
if you want to mail me at work (you don't), use arjan (at) linux.intel.com


  reply	other threads:[~2006-08-20 15:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-17 19:45 Ron Yorston
2006-08-20  5:46 ` Andrew Morton
2006-08-20 11:48   ` Ron Yorston
2006-08-20 15:24     ` Arjan van de Ven [this message]
2006-08-20 15:33       ` Val Henson
2006-08-28 19:41         ` Valerie Henson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1156087499.23756.39.camel@laptopd505.fenrus.org \
    --to=arjan@infradead.org \
    --cc=akpm@osdl.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmy@tigress.co.uk \
    --cc=val.henson@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®