From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Eric Sesterhenn <snakebyte@gmx.de>
Cc: linux-kernel@vger.kernel.org, osst@riede.org
Subject: Re: [Patch] Signdness issue in drivers/scsi/osst.c
Date: Sun, 20 Aug 2006 19:18:37 +0100 [thread overview]
Message-ID: <1156097917.4051.30.camel@localhost.localdomain> (raw)
In-Reply-To: <1156015188.19657.7.camel@alice>
Ar Sad, 2006-08-19 am 21:19 +0200, ysgrifennodd Eric Sesterhenn:
> Hi,
>
> another signdness warning from gcc 4.1
>
> drivers/scsi/osst.c:5154: warning: comparison of unsigned expression < 0 is always false
>
> The problem is that blk is defined as unsigned, but all usages of it
> are normal int cases. osst_get_frame_position() and osst_get_sector()
> return ints and can return negative values. If blk stays an unsigned int,
> the error check is useless.
Acked-by: Alan Cox <alan@redhat.com>
prev parent reply other threads:[~2006-08-20 17:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-19 19:19 Eric Sesterhenn
2006-08-20 18:18 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156097917.4051.30.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=osst@riede.org \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome