From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Eric Sesterhenn <snakebyte@gmx.de>
Cc: linux-kernel@vger.kernel.org, becker@scyld.com, jgarzik@pobox.com
Subject: Re: [Patch] Signedness issue in drivers/net/3c515.c
Date: Sun, 20 Aug 2006 19:22:32 +0100 [thread overview]
Message-ID: <1156098152.4051.34.camel@localhost.localdomain> (raw)
In-Reply-To: <1156009077.18374.1.camel@alice>
Ar Sad, 2006-08-19 am 19:37 +0200, ysgrifennodd Eric Sesterhenn:
> hi,
>
> while playing with gcc 4.1 -Wextra warnings, I came across this one:
>
> drivers/net/3c515.c:1027: warning: comparison of unsigned expression >= 0 is always true
>
> Since i is unsigned the >= 0 check in the for loop is always true,
> so we might spin there forever unless the if condition triggers.
> Since i is only used in this loop, this patch changes it to
> an integer.
>
> Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
>
Acked-by: Alan Cox <alan@redhat.com>
[And put JG on the Cc:]
next prev parent reply other threads:[~2006-08-20 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-19 17:37 Eric Sesterhenn
2006-08-20 18:22 ` Alan Cox [this message]
2006-08-21 21:05 ` Andrew Morton
2006-08-21 22:13 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156098152.4051.34.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=becker@scyld.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=snakebyte@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome