From: Arjan van de Ven <arjan@infradead.org>
To: ego@in.ibm.com
Cc: rusty@rustcorp.com.au, torvalds@osdl.org, akpm@osdl.org,
linux-kernel@vger.kernel.org, arjan@intel.linux.com,
mingo@elte.hu, davej@redhat.com, dipankar@in.ibm.com,
vatsa@in.ibm.com, ashok.raj@intel.com
Subject: Re: [RFC][PATCH 4/4] Rename lock_cpu_hotplug/unlock_cpu_hotplug
Date: Thu, 24 Aug 2006 13:00:00 +0200 [thread overview]
Message-ID: <1156417200.3014.54.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <20060824103417.GE2395@in.ibm.com>
On Thu, 2006-08-24 at 16:04 +0530, Gautham R Shenoy wrote:
>
>
> This patch renames lock_cpu_hotplug to cpu_hotplug_disable and
> unlock_cpu_hotplug to cpu_hotplug_enable throughout the kernel.
Hi,
to be honest I dislike the new names too. You turned it into a refcount,
which is good, but the normal linux name for such refcount functions is
_get and _put..... and in addition the refcount technically isn't
hotplug specific, all you want is to keep the kernel data for the
processor as being "used", so cpu_get() and cpu_put() would sound
reasonable names to me, or cpu_data_get() cpu_data_put().
Greetings,
Arjan van de Ven
next prev parent reply other threads:[~2006-08-24 11:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-24 10:34 Gautham R Shenoy
2006-08-24 11:00 ` Arjan van de Ven [this message]
2006-08-24 14:03 ` Gautham R Shenoy
2006-08-24 14:16 ` Arjan van de Ven
2006-08-24 14:55 ` Nick Piggin
2006-08-24 15:00 ` Ingo Molnar
2006-08-24 15:53 ` Nick Piggin
2006-08-25 3:53 ` Gautham R Shenoy
2006-08-27 7:59 ` Paul Jackson
2006-08-27 8:42 ` Keith Owens
2006-08-27 9:10 ` Paul Jackson
2006-08-29 18:05 ` Paul E. McKenney
2006-08-29 19:31 ` Paul Jackson
2006-08-29 20:03 ` Paul E. McKenney
2006-08-30 2:38 ` Paul Jackson
2006-08-30 15:14 ` Paul E. McKenney
2006-08-30 17:54 ` Paul Jackson
2006-08-30 18:13 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156417200.3014.54.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=arjan@intel.linux.com \
--cc=ashok.raj@intel.com \
--cc=davej@redhat.com \
--cc=dipankar@in.ibm.com \
--cc=ego@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=torvalds@osdl.org \
--cc=vatsa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®