From: David Woodhouse <dwmw2@infradead.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH 1/4] Inconsistent extern declarations.
Date: Thu, 24 Aug 2006 18:50:25 +0100 [thread overview]
Message-ID: <1156441825.3012.184.camel@pmac.infradead.org> (raw)
In-Reply-To: <20060824161344.GB5205@martell.zuzino.mipt.ru>
On Thu, 2006-08-24 at 20:13 +0400, Alexey Dobriyan wrote:
> Better move proto to include/net/ipx.h since net/ipx/af_ipx.c already
> including it.
>
> In general, this patch is wrong. Every external declaration and every
> proto should be in only one place.
Yes, there's a lot of merit in that argument.
--
dwmw2
next prev parent reply other threads:[~2006-08-24 17:50 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1156429585.3012.58.camel@pmac.infradead.org>
2006-08-24 15:24 ` [PATCH 0/4] Compile kernel with -fwhole-program --combine David Woodhouse
2006-08-24 16:48 ` Jan Engelhardt
2006-08-24 17:05 ` David Woodhouse
2006-08-25 6:01 ` Jan Engelhardt
2006-08-25 7:26 ` Sam Ravnborg
2006-08-25 10:14 ` David Woodhouse
2006-08-25 8:55 ` David Woodhouse
2006-08-25 9:11 ` Jan Engelhardt
2006-08-25 9:45 ` David Woodhouse
2006-08-25 9:51 ` Jan Engelhardt
2006-08-25 10:01 ` David Woodhouse
2006-08-24 17:15 ` [OLPC-devel] " Arnd Bergmann
2006-08-24 17:25 ` David Woodhouse
2006-08-24 21:49 ` Adrian Bunk
2006-08-24 21:54 ` David Woodhouse
2006-08-25 20:11 ` Rob Landley
2006-08-25 20:35 ` David Woodhouse
2006-08-26 1:59 ` Segher Boessenkool
2006-08-28 10:52 ` Helge Hafting
2006-08-28 11:03 ` Jan Engelhardt
2006-08-28 11:21 ` David Woodhouse
2006-09-01 19:35 ` Ian Stirling
2006-09-01 21:15 ` David Woodhouse
2006-08-24 15:25 ` [PATCH 1/4] Inconsistent extern declarations David Woodhouse
2006-08-24 16:13 ` Alexey Dobriyan
2006-08-24 17:50 ` David Woodhouse [this message]
2006-08-24 21:17 ` Adrian Bunk
2006-08-24 15:26 ` [PATCH 2/4] Core support for --combine -fwhole-program David Woodhouse
2006-08-24 17:27 ` Josh Triplett
2006-08-24 17:33 ` David Woodhouse
2006-08-24 21:33 ` Adrian Bunk
2006-08-25 9:37 ` David Woodhouse
2006-08-25 10:30 ` Adrian Bunk
2006-08-25 10:40 ` David Woodhouse
2006-08-24 15:26 ` [PATCH 3/4] Add __global tag where needed David Woodhouse
2006-08-24 21:30 ` Adrian Bunk
2006-08-25 9:52 ` David Woodhouse
2006-08-25 10:26 ` Adrian Bunk
2006-08-25 10:34 ` David Woodhouse
2006-08-25 10:50 ` Adrian Bunk
2006-08-24 15:28 ` [PATCH 4/4] Some extra --combine hacks David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156441825.3012.184.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®