From: Arjan van de Ven <arjan@infradead.org>
To: David Howells <dhowells@redhat.com>
Cc: Andreas Mohr <andi@rhlx01.fht-esslingen.de>,
Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] lib/rwsem.c: un-inline rwsem_down_failed_common()
Date: Tue, 29 Aug 2006 11:59:09 +0200 [thread overview]
Message-ID: <1156845549.2722.45.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <11555.1156845039@warthog.cambridge.redhat.com>
On Tue, 2006-08-29 at 10:50 +0100, David Howells wrote:
> Andreas Mohr <andi@rhlx01.fht-esslingen.de> wrote:
>
> > Un-inlining rwsem_down_failed_common() (two callsites) reduced
> > lib/rwsem.o on my Athlon, gcc 4.1.2 from 5935 to 5480 Bytes (455 Bytes saved).
>
> Maybe this should be judged according to CONFIG_CC_OPTIMIZE_FOR_SIZE.
gcc already does this if you don't manually specify the inline
keyword ;)
static functions get inlined if they're small enough in relation to the
nr of call sites, where "small enough" is a function of -O2 vs -Os. So
leaving away inline makes gcc do its smarts.
--
if you want to mail me at work (you don't), use arjan (at) linux.intel.com
prev parent reply other threads:[~2006-08-29 9:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-28 20:04 Andreas Mohr
2006-08-29 9:50 ` David Howells
2006-08-29 9:59 ` Arjan van de Ven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156845549.2722.45.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=akpm@osdl.org \
--cc=andi@rhlx01.fht-esslingen.de \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®