From: Dave Kleikamp <shaggy@austin.ibm.com>
To: Richard Knutsson <ricknu-0@student.ltu.se>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org, hch@infradead.org
Subject: Re: [PATCH 2.6.18-rc4-mm2] fs/jfs: Conversion to generic boolean
Date: Tue, 29 Aug 2006 08:53:11 -0500 [thread overview]
Message-ID: <1156859592.8082.13.camel@kleikamp.austin.ibm.com> (raw)
In-Reply-To: <44F445A0.9000306@student.ltu.se>
On Tue, 2006-08-29 at 15:48 +0200, Richard Knutsson wrote:
> Dave Kleikamp wrote:
>
> >On Tue, 2006-08-29 at 01:33 +0200, Richard Knutsson wrote:
> >>What do you say, can you hold on it for a while (can't be urgent, can
> >>it?) and see how the conversion go. Will take time for it during this
> >>week(end) and if the result is that almost no maintainer wants it, then...
> >>Just seem strange to having a boolean function but declaring it integer,
> >>for (in my knowledge) no reason.
> >>
> >>
> >
> >Sounds good to me. I think I'll go ahead and kill the use of TRUE and
> >FALSE, but hold off on the type change for now.
> >
> >
> To 0/1 or false/true?
I was going to go ahead with the 0/1 thing, but on second thought, I'll
just hold off on the whole thing and see where this ends up. I may go
ahead and just accept your original patch. We lived with the ugly,
locally-defined TRUE & FALSE this long. Waiting a little longer can't
hurt.
--
David Kleikamp
IBM Linux Technology Center
prev parent reply other threads:[~2006-08-29 13:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-26 17:37 Richard Knutsson
2006-08-28 14:22 ` Dave Kleikamp
2006-08-28 20:42 ` Richard Knutsson
2006-08-28 21:11 ` Dave Kleikamp
2006-08-28 23:33 ` Richard Knutsson
2006-08-29 12:37 ` Dave Kleikamp
2006-08-29 13:48 ` Richard Knutsson
2006-08-29 13:53 ` Dave Kleikamp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156859592.8082.13.camel@kleikamp.austin.ibm.com \
--to=shaggy@austin.ibm.com \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ricknu-0@student.ltu.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®