From: Dave Hansen <haveblue@us.ibm.com>
To: Sukadev Bhattiprolu <sukadev@us.ibm.com>
Cc: kraxel@bytesex.org, Andrew Morton <akpm@osdl.org>,
clg@fr.ibm.com, serue@us.ibm.com, Containers@lists.osdl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kthread: saa7134-tvaudio.c
Date: Tue, 29 Aug 2006 14:22:26 -0700 [thread overview]
Message-ID: <1156886546.5408.191.camel@localhost.localdomain> (raw)
In-Reply-To: <20060829211555.GB1945@us.ibm.com>
On Tue, 2006-08-29 at 14:15 -0700, Sukadev Bhattiprolu wrote:
> @@ -1004,15 +1002,16 @@ int saa7134_tvaudio_init2(struct saa7134
> break;
> }
>
> - dev->thread.pid = -1;
> + dev->thread.task = NULL;
> if (my_thread) {
...
This is _really_ minor, but I think dev is kzmalloc()'d. I haven't
examined it closely enough to tell if these devices get reused, but this
one _might_ be unnecessary. Certainly no big deal either way, and it
certainly doesn't make anything worse.
-- Dave
next prev parent reply other threads:[~2006-08-29 21:22 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-29 21:15 Sukadev Bhattiprolu
2006-08-29 21:22 ` Dave Hansen [this message]
2006-08-29 21:39 ` Andrew Morton
2006-08-29 22:39 ` Eric W. Biederman
2006-08-30 12:39 ` Eric W. Biederman
2006-08-30 14:07 ` Cedric Le Goater
2006-08-30 15:43 ` Eric W. Biederman
2006-08-30 16:18 ` Cedric Le Goater
2006-08-30 16:35 ` [Devel] " Kirill Korotaev
2006-08-30 16:38 ` Kir Kolyshkin
2006-08-30 16:30 ` Cedric Le Goater
2006-08-30 16:49 ` Andrew Morton
2006-08-30 17:36 ` Mauro Carvalho Chehab
2006-08-31 1:02 ` Sukadev Bhattiprolu
2006-08-31 1:05 ` [PATCH] kthread: tvaudio.c Sukadev Bhattiprolu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1156886546.5408.191.camel@localhost.localdomain \
--to=haveblue@us.ibm.com \
--cc=Containers@lists.osdl.org \
--cc=akpm@osdl.org \
--cc=clg@fr.ibm.com \
--cc=kraxel@bytesex.org \
--cc=linux-kernel@vger.kernel.org \
--cc=serue@us.ibm.com \
--cc=sukadev@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome