From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751185AbWH3RTq (ORCPT ); Wed, 30 Aug 2006 13:19:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751183AbWH3RTq (ORCPT ); Wed, 30 Aug 2006 13:19:46 -0400 Received: from stat9.steeleye.com ([209.192.50.41]:2242 "EHLO hancock.sc.steeleye.com") by vger.kernel.org with ESMTP id S1751172AbWH3RTp (ORCPT ); Wed, 30 Aug 2006 13:19:45 -0400 Subject: Re: [PATCH] aic94xx: Increase can_queue and cmds_per_lun From: James Bottomley To: "Darrick J. Wong" Cc: Linux Kernel Mailing List , linux-scsi@vger.kernel.org, Alexis Bruemmer , Mike Anderson , Konrad Rzeszutek In-Reply-To: <44F3CF6E.1070000@us.ibm.com> References: <44F3CF6E.1070000@us.ibm.com> Content-Type: text/plain Date: Wed, 30 Aug 2006 13:19:43 -0400 Message-Id: <1156958383.7701.2.camel@mulgrave.il.steeleye.com> Mime-Version: 1.0 X-Mailer: Evolution 2.2.3 (2.2.3-4.fc4) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2006-08-28 at 22:23 -0700, Darrick J. Wong wrote: > - .cmd_per_lun = 1, > + .cmd_per_lun = 2, This is an old piece of code. Today we use 1 for the cmd_per_lun of non-TCQ devices. > + aic94xx_sht.can_queue = asd_ha->hw_prof.max_scbs - ASD_FREE_SCBS; This is unnecessary unless you alter it before host alloc (which is where it takes the shost values from the template). Also, I think if you look at the rest of the driver, it's careful to account for the need for required scbs in its internal queueing algorithms, so the ASD_FREE_SCBS should be unnecessary. > + shost->can_queue = aic94xx_sht.can_queue; James