From: Arjan van de Ven <arjan@infradead.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Andrew Morton <akpm@osdl.org>, Dave Airlie <airlied@linux.ie>,
linux-kernel@vger.kernel.org
Subject: Re: [FOR 2.6.18 FIX][PATCH] drm: radeon flush TCL VAP for vertex program enable/disable
Date: Thu, 31 Aug 2006 08:27:13 +0200 [thread overview]
Message-ID: <1157005633.2715.62.camel@laptopd505.fenrus.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0608301550090.27779@g5.osdl.org>
On Wed, 2006-08-30 at 15:53 -0700, Linus Torvalds wrote:
>
> On Wed, 30 Aug 2006, Andrew Morton wrote:
> >
> > That's a somewhat weird-looking patch. It adds code which is quite
> > dissimilar from all the other cases in that switch statement.
>
> It looks ok to me, although you have to look into the caller to see why it
> does what it does.
>
> It would be "prettier" if it changed the size and data of the incoming
> packet instead, but the code as is isn't actually set up to be able to do
> that (the size setup and verification stuff is done before the fixup).
>
> That said, I'd have expected that the VAP state flush is really something
> that the _client_ should do when it generates the commands, not the kernel
> after the fact.
but the client is unprivileged userspace!
The kernel needs to ensure correctness and probably even enforce it.
prev parent reply other threads:[~2006-08-31 6:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-30 22:17 Dave Airlie
2006-08-30 22:41 ` Andrew Morton
2006-08-30 22:50 ` Dave Airlie
2006-08-30 22:53 ` Linus Torvalds
2006-08-30 23:03 ` Dave Airlie
2006-08-31 6:27 ` Arjan van de Ven [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157005633.2715.62.camel@laptopd505.fenrus.org \
--to=arjan@infradead.org \
--cc=airlied@linux.ie \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®