From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964832AbWIDPBJ (ORCPT ); Mon, 4 Sep 2006 11:01:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751454AbWIDPBJ (ORCPT ); Mon, 4 Sep 2006 11:01:09 -0400 Received: from out2.smtp.messagingengine.com ([66.111.4.26]:7093 "EHLO out2.smtp.messagingengine.com") by vger.kernel.org with ESMTP id S1751452AbWIDPBG (ORCPT ); Mon, 4 Sep 2006 11:01:06 -0400 X-Sasl-enc: iXfpCZkBQOGoWNdTNiUwJWSADU7DKgsRACuvxDj8JhiH 1157382064 Subject: Re: [PATCH 0/7] Permit filesystem local caching and NFS superblock sharing [try #13] From: Ian Kent To: David Howells Cc: Andrew Morton , Trond Myklebust , torvalds@osdl.org, steved@redhat.com, linux-fsdevel@vger.kernel.org, linux-cachefs@redhat.com, nfsv4@linux-nfs.org, linux-kernel@vger.kernel.org In-Reply-To: <32013.1157377601@warthog.cambridge.redhat.com> References: <1157376295.3240.13.camel@raven.themaw.net> <20060901195009.187af603.akpm@osdl.org> <20060831102127.8fb9a24b.akpm@osdl.org> <20060830135503.98f57ff3.akpm@osdl.org> <20060830125239.6504d71a.akpm@osdl.org> <20060830193153.12446.24095.stgit@warthog.cambridge.redhat.com> <27414.1156970238@warthog.cambridge.redhat.com> <9849.1157018310@warthog.cambridge.redhat.com> <9534.1157116114@warthog.cambridge.redhat.com> <20060901093451.87aa486d.akpm@osdl.org> <1157130044.5632.87.camel@localhost> <28945.1157370732@warthog.cambridge.redhat.com> <32013.1157377601@warthog.cambridge.redhat.com> Content-Type: text/plain Date: Mon, 04 Sep 2006 23:00:57 +0800 Message-Id: <1157382057.4166.0.camel@raven.themaw.net> Mime-Version: 1.0 X-Mailer: Evolution 2.6.3 (2.6.3-1.fc5.5) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2006-09-04 at 14:46 +0100, David Howells wrote: > Ian Kent wrote: > > > This is the point I'm trying to make. > > I'm able to reproduce this with exports that don't have "nohide". > > The mkdir used to return EEXIST, possibly before getting to the EACCES > > test. It appears to be a change in semantic behavior and I can't see > > where it is coming from. autofs expects an EEXIST but not an EACCES and > > so doesn't perform the mount. I could ignore the EACCES but that would > > be cheating. > > Here's something you can try: Look in fs/nfs/dir.c. Find nfs_lookup(). In > there, find the following lines: > > /* If we're doing an exclusive create, optimize away the lookup */ > if (nfs_is_exclusive_create(dir, nd)) > goto no_entry; > > Comment that bit out and see what the effect it. OK. But tomorrow. I'll let you know. Ian