From: Steven Whitehouse <swhiteho@redhat.com>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: linux-kernel@vger.kernel.org,
Russell Cattelan <cattelan@redhat.com>,
David Teigland <teigland@redhat.com>, Ingo Molnar <mingo@elte.hu>,
hch@infradead.org
Subject: Re: [PATCH 02/16] GFS2: Core locking interface
Date: Mon, 04 Sep 2006 16:40:01 +0100 [thread overview]
Message-ID: <1157384401.3384.956.camel@quoit.chygwyn.com> (raw)
In-Reply-To: <Pine.LNX.4.61.0609041108570.11217@yvahk01.tjqt.qr>
Hi,
On Mon, 2006-09-04 at 11:22 +0200, Jan Engelhardt wrote:
> Hi,
>
>
> >Unfortunately thats not possible as the struct gfs2_sbd is actually
> >changed lower down the call chain, but only in the lock_dlm module.
>
> +void gfs2_lm_unmount(struct gfs2_sbd *sdp)
> +{
> + if (likely(!test_bit(SDF_SHUTDOWN, &sdp->sd_flags)))
> + gfs2_unmount_lockproto(&sdp->sd_lockstruct);
> +}
>
> I can't follow... test_bit does not modify *sdp or sdp->sd_flags, and
> gfs2_unmount_lockproto does not either.
>
sd_lockstruct is part of the superblock and fields in the lockstruct are
changed by (for example) fs/gfs2/locking/dlm/mount.c: gdlm_unmount() so
I don't think its valid to mark the superblock const here (despite being
a great fan of using const in general).
Steve.
next prev parent reply other threads:[~2006-09-04 15:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-31 13:29 Steven Whitehouse
2006-09-01 7:19 ` Jan Engelhardt
2006-09-01 11:10 ` Ingo Molnar
2006-09-04 9:01 ` Steven Whitehouse
2006-09-04 9:22 ` Jan Engelhardt
2006-09-04 15:40 ` Steven Whitehouse [this message]
2006-09-04 17:51 ` Jan Engelhardt
-- strict thread matches above, loose matches on Subject: below --
2006-04-21 16:10 Steven Whitehouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157384401.3384.956.camel@quoit.chygwyn.com \
--to=swhiteho@redhat.com \
--cc=cattelan@redhat.com \
--cc=hch@infradead.org \
--cc=jengelh@linux01.gwdg.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=teigland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®