From: Michael De Backer <micdb@skynet.be>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] alim15x3.c: M5229 (rev c8) support for DMA cd-writer
Date: Sat, 09 Sep 2006 21:12:25 +0200 [thread overview]
Message-ID: <1157829145.6648.11.camel@mws.local.net> (raw)
In-Reply-To: <1157818525.6877.57.camel@localhost.localdomain>
Le samedi 09 septembre 2006 à 17:15 +0100, Alan Cox a écrit :
> Ar Sad, 2006-09-09 am 17:37 +0200, ysgrifennodd Michael De Backer:
> > - else if (m5229_revision == 0xc7)
> > + else if (m5229_revision == 0xc7 || 0xc8)
>
> I don't think that is what you mean..
>
> NAK
Indeed, let's try again (please forgive my dumbness).
Configuration bits are not set properly for DMA on some chipset
revisions. It has already been corrected for M5229 (rev c7) but not for
M5229 (rev c8). This leads to the bug described at
http://bugzilla.kernel.org/show_bug.cgi?id=5786 (lost interrupt + ide
bus hangs).
Signed-off-by: Michael De Backer <micdb@skynet.be>
---
The following patch is against the 2.6.18-rc6 or 2.6.18-rc6-mm1 kernel:
--- linux/drivers/ide/pci/alim15x3.c.orig 2006-09-09
16:07:07.000000000 +0200
+++ linux/drivers/ide/pci/alim15x3.c 2006-09-09 16:08:25.000000000
+0200
@@ -730,7 +730,7 @@ static unsigned int __devinit ata66_ali1
if(m5229_revision <= 0x20)
tmpbyte = (tmpbyte & (~0x02)) | 0x01;
- else if (m5229_revision == 0xc7)
+ else if (m5229_revision == 0xc7 || m5229_revision == 0xc8)
tmpbyte |= 0x03;
else
tmpbyte |= 0x01;
next prev parent reply other threads:[~2006-09-09 19:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-09 15:37 Michael De Backer
2006-09-09 16:15 ` Alan Cox
2006-09-09 19:12 ` Michael De Backer [this message]
2006-09-10 0:35 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157829145.6648.11.camel@mws.local.net \
--to=micdb@skynet.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome