From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Marton Balint <cus@fazekas.hu>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org, torvalds@osdl.org
Subject: Re: Driver_data is probably zero in serverworks IDE driver
Date: Sat, 09 Sep 2006 21:36:37 +0100 [thread overview]
Message-ID: <1157834197.6877.72.camel@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.61.0609091840170.30278@cinke.fazekas.hu>
Ar Sad, 2006-09-09 am 19:19 +0200, ysgrifennodd Marton Balint:
> Please take a look at commit f201f5046ddaeeccb036bdf6848549bf5cb51bb1.
> This commit introduced the usage of the PCI_DEVICE macro, but this macro
> does not set class and class_mask so I think now we set .class instead of
> .driver_data. The drivers that are also affected by this commit may
> have similar problems.
Yes it looks to be the case, and PCI_DEVICE_CLASS() macros don't help as
they assign in differing orders.
The following drivers appear to be broken from this
Aec62xx.c All
Serverworks.c OSB4/CSB5/CSB6/CSB6-2/HT1000
Actual breakage will affect CSB6/CSB6-2/HT1000, and all the AEC6xxx
chips in various ways.
Unfortunately it appears I missed the bug, nobody checked the diff and
nobody ever ran -mm with these chipsets so it somehow got through. I'll
look at rolling a patch but it might be Monday. Until then anyone
rolling a 2.6.18 tree should revert the PCI table changes in serverworks
and aec62xx.
Alan
prev parent reply other threads:[~2006-09-09 20:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-09 17:19 Marton Balint
2006-09-09 20:36 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1157834197.6877.72.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=cus@fazekas.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®