From: Denys Vlasenko <vda.linux@googlemail.com>
To: Dave Hansen <dave@linux.vnet.ibm.com>
Cc: akpm@linux-foundation.org, containers@lists.linux-foundation.org,
bblum@google.com, linux-kernel@vger.kernel.org,
menage@google.com
Subject: Re: [RFC][PATCH] flexible array implementation
Date: Tue, 21 Jul 2009 18:57:50 +0200 [thread overview]
Message-ID: <1158166a0907210957p6fb73ed7pc7f5bb9f9ad6eac2@mail.gmail.com> (raw)
In-Reply-To: <20090721160333.96AA4D3D@kernel>
On Tue, Jul 21, 2009 at 6:03 PM, Dave Hansen<dave@linux.vnet.ibm.com> wrote:
> +static inline struct flex_array_part *
> +__fa_get_part(struct flex_array *fa, int part_nr, gfp_t flags)
> +{
> + struct flex_array_part *part = NULL;
> + if (part_nr > __nr_part_ptrs())
> + return NULL;
> + part = fa->parts[part_nr];
> + if (!part) {
> + part = kmalloc(FLEX_ARRAY_PART_SIZE, flags);
> + if (!part)
> + return NULL;
> + fa->parts[part_nr] = part;
> + }
> + return part;
> +}
This is far too big to be an inline.
--
vda
next prev parent reply other threads:[~2009-07-21 16:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-21 16:03 Dave Hansen
2009-07-21 16:47 ` Mike Waychison
2009-07-21 17:22 ` Dave Hansen
2009-07-21 16:57 ` Denys Vlasenko [this message]
2009-07-21 17:25 ` Dave Hansen
2009-07-21 20:18 ` Andrew Morton
2009-07-21 21:56 ` Dave Hansen
2009-07-21 22:33 ` Andrew Morton
2009-07-21 20:28 ` Paul Menage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1158166a0907210957p6fb73ed7pc7f5bb9f9ad6eac2@mail.gmail.com \
--to=vda.linux@googlemail.com \
--cc=akpm@linux-foundation.org \
--cc=bblum@google.com \
--cc=containers@lists.linux-foundation.org \
--cc=dave@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=menage@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®