From: Rohit Seth <rohitseth@google.com>
To: "Björn Steinbrink" <B.Steinbrink@gmx.de>
Cc: Andrew Morton <akpm@osdl.org>,
devel@openvz.org, CKRM-Tech <ckrm-tech@lists.sourceforge.net>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [Patch03/05]- Containers: Initialization and Configfs interface
Date: Fri, 15 Sep 2006 09:47:26 -0700 [thread overview]
Message-ID: <1158338846.12311.30.camel@galaxy.corp.google.com> (raw)
In-Reply-To: <20060915163027.GA5285@atjola.homenet>
On Fri, 2006-09-15 at 18:30 +0200, Björn Steinbrink wrote:
> On 2006.09.14 18:41:26 -0700, Rohit Seth wrote:
> > +static int __init configfs_container_init(void)
> > +{
> > + int ret;
> > +
> > + config_group_init(&containerfs_group.cs_subsys.su_group);
> > + init_MUTEX(&containerfs_group.cs_subsys.su_sem);
> > + ret = configfs_register_subsystem(&containerfs_group.cs_subsys);
> > +
> > + if (ret)
> > + printk(KERN_ERR "Error %d while registering container subsystem\n", ret);
> > + else {
> > + container_wq = create_workqueue("Kcontainerd");
> > + if (container_wq == NULL) {
> > + ret = -ENOMEM;
> > + printk(KERN_ERR "Unable to create Container controllers");
>
> Shouldn't the subsystem be unregistered here?
>
Yes. Indeed. I'll fix it.
Thanks,
-rohit
> > + }
> > + }
> > + return ret;
> > +}
>
> Regards,
> Björn
next prev parent reply other threads:[~2006-09-15 16:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-15 1:41 Rohit Seth
2006-09-15 16:30 ` Björn Steinbrink
2006-09-15 16:47 ` Rohit Seth [this message]
2006-09-19 15:38 ` Valdis.Kletnieks
2006-09-19 16:33 ` Rohit Seth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1158338846.12311.30.camel@galaxy.corp.google.com \
--to=rohitseth@google.com \
--cc=B.Steinbrink@gmx.de \
--cc=akpm@osdl.org \
--cc=ckrm-tech@lists.sourceforge.net \
--cc=devel@openvz.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome