From: David Woodhouse <dwmw2@infradead.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 1/8] extend make headers_check to detect more problems
Date: Mon, 18 Sep 2006 07:45:36 +0100 [thread overview]
Message-ID: <1158561937.24527.277.camel@pmac.infradead.org> (raw)
In-Reply-To: <20060918062152.GA7088@uranus.ravnborg.org>
On Mon, 2006-09-18 at 08:21 +0200, Sam Ravnborg wrote:
> Can't we do this with a hdrchk$$$ filename to avoid using
> random entropy for each compile?
I'd like to move to a scheme where we do headers_install and
headers_check _without_ starting with a rm -rf
$(HDR_INSTALL_PATH)/include.
We could probably do it by adding a rule along the lines of
$(filter-out $(unifdef-y) $(header-y),$(wildcard $(INSTALL_HDR_PATH)/$(dst)/*.h):
rm $@
... i.e. remove every .h file from the destination directory except the
ones we just created.
Then we can make $(INSTALL_HDR_PATH)/$(dst)/%.h depend on
$(srctree)/$(src)/%.h so that it doesn't get re-exported unless it's
changed. And we can keep a stamp file around (or the output of the test
compilation after Arnd's patch) which shows that the _check_ step has
been done too. Something like .checked.%.h
After we do that, a second invocation of 'make headers_check' should
have nothing to do, which will encourage people to keep using it.
--
dwmw2
next prev parent reply other threads:[~2006-09-18 6:45 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1158079495.9189.125.camel@hades.cambridge.redhat.com>
2006-09-18 1:27 ` [patch 0/8] Re: All arch maintainers: 'make headers_check' fails on most architectures Arnd Bergmann
2006-09-18 1:27 ` [patch 1/8] extend make headers_check to detect more problems Arnd Bergmann
2006-09-18 6:21 ` Sam Ravnborg
2006-09-18 6:45 ` David Woodhouse [this message]
2006-09-21 15:13 ` David Woodhouse
2006-09-18 8:05 ` Arnd Bergmann
2006-09-18 8:10 ` David Woodhouse
2006-09-23 11:04 ` David Woodhouse
2006-09-23 13:18 ` Arnd Bergmann
2006-09-18 1:27 ` [patch 2/8] fix byteorder headers for make headers_check Arnd Bergmann
2006-09-18 1:27 ` [patch 3/8] hide kernel-only parts of some installed headers Arnd Bergmann
2006-09-18 1:27 ` [patch 4/8] fix exported flock64 constants Arnd Bergmann
2006-09-18 1:27 ` [patch 5/8] add missing #includes in user space parts of headers Arnd Bergmann
2006-09-18 1:27 ` [patch 6/8] annotate header files for make headers_check Arnd Bergmann
2006-09-18 1:27 ` [patch 8/8] annotate netfilter header " Arnd Bergmann
2006-09-18 1:37 ` [patch 7/8] annotate if_* " Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1158561937.24527.277.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=arnd@arndb.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®