From: David Woodhouse <dwmw2@infradead.org>
To: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [-mm patch 2/3] AVR32 MTD: Unlock flash if necessary (try 2)
Date: Mon, 18 Sep 2006 09:14:20 +0100 [thread overview]
Message-ID: <1158567260.24527.313.camel@pmac.infradead.org> (raw)
In-Reply-To: <20060918101224.12508491@cad-250-152.norway.atmel.com>
On Mon, 2006-09-18 at 10:12 +0200, Haavard Skinnemoen wrote:
> On Fri, 15 Sep 2006 16:32:26 +0100
> David Woodhouse <dwmw2@infradead.org> wrote:
>
> > On Fri, 2006-09-15 at 16:37 +0200, Haavard Skinnemoen wrote:
> > > If a cfi_cmdset_0002 fixup installs an unlock() operation, use it
> > > to unlock the whole flash after the erase regions have been set up.
> >
> > There are cmdset_0001 chips which have this affliction too. I was
> > thinking of having a flag MTD_STUPID_LOCK which you set when you
> > determine that it's one of these chips, then add_mtd_device() can do
> > the unlocking... or add_mtd_partitions() can do it but _only_ for
> > writable partitions.
>
> Ok, so how about something like this? Which other chips should be marked?
Looks good; thanks. There's some Intel chips which need to be so marked
but I'll let the Intel folks deal with that.
I'll apply it to my git tree, but only _after_ Linus has pulled from it
as requested a couple of days ago -- I think this should wait for 2.6.19
rather than being slipped in at the last moment.
--
dwmw2
next prev parent reply other threads:[~2006-09-18 8:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-15 14:31 [-mm patch 0/3] AVR32 MTD: Introduction " Haavard Skinnemoen
2006-09-15 14:35 ` [-mm patch 1/3] AVR32 MTD: Static Memory Controller driver " Haavard Skinnemoen
2006-09-15 14:37 ` [-mm patch 2/3] AVR32 MTD: Unlock flash if necessary " Haavard Skinnemoen
2006-09-15 14:38 ` [-mm patch 3/3] AVR32 MTD: AT49BV6416 platform device for ATSTK1000 " Haavard Skinnemoen
2006-09-15 15:32 ` [-mm patch 2/3] AVR32 MTD: Unlock flash if necessary " David Woodhouse
2006-09-18 8:12 ` Haavard Skinnemoen
2006-09-18 8:14 ` David Woodhouse [this message]
2006-09-18 8:21 ` Haavard Skinnemoen
2006-09-18 8:21 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1158567260.24527.313.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=akpm@osdl.org \
--cc=hskinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®