From: Richard Purdie <rpurdie@rpsys.net>
To: Paul Collins <paul@briny.ondioline.org>, akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] leds: turn LED off when changing triggers
Date: Tue, 19 Sep 2006 22:18:18 +0100 [thread overview]
Message-ID: <1158700698.19123.5.camel@localhost.localdomain> (raw)
In-Reply-To: <87u034y21v.fsf@briny.internal.ondioline.org>
On Tue, 2006-09-19 at 15:21 +1200, Paul Collins wrote:
> I was playing with LED triggers when I noticed that changing from
> heartbeat (or ide-disk) to "none" at the right moment would leave the
> LED stuck on. This is easy to reproduce by doing "find / >/dev/null"
> with the ide-disk trigger enabled and then switching to "none".
>
> Here is a patch that fixes the problem by explicitly turning the LED
> off after removing the existing trigger.
Looks good to me, thanks.
> Signed-off-by: Paul Collins <paul@ondioline.org>
Acked-by: Richard Purdie <rpurdie@rpsys.net>
prev parent reply other threads:[~2006-09-19 21:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-19 3:21 Paul Collins
2006-09-19 21:18 ` Richard Purdie [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1158700698.19123.5.camel@localhost.localdomain \
--to=rpurdie@rpsys.net \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@briny.ondioline.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome