mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Tejun Heo <htejun@gmail.com>,
	rmk@arm.linux.org.uk
Subject: Re: [PATCH] libata: rework legacy handling to remove much of the cruft
Date: Mon, 25 Sep 2006 12:18:02 +0100	[thread overview]
Message-ID: <1159183082.11049.49.camel@localhost.localdomain> (raw)
In-Reply-To: <1159179290.320.11.camel@pmac.infradead.org>

Ar Llu, 2006-09-25 am 11:14 +0100, ysgrifennodd David Woodhouse:
> We should register the non-discoverable devices as platform devices (or
> of_devices, or something), and not just hardcode stuff like this in
> asm/foo.h headers

That would be too late. Those "constants"[1] are part of the actual PCI
bus setup. I have some patches to push most of them into
drivers/pci/quirks.c. We cannot use platform devices for this in most
cases because we already have a device for it - the PCI one.

In the non PCI case we can use platform devices and we do, but the
platform device itself has to know what I/O ports are being used so you
end up back with the "constants".

The old IDE layer works this way too except that it doesn't use platform
devices at all.

Alan
[1] as in "constants aren't, variables won't"




      reply	other threads:[~2006-09-25 10:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200609241805.k8OI5Xkn007593@hera.kernel.org>
2006-09-25 10:14 ` David Woodhouse
2006-09-25 11:18   ` Alan Cox [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1159183082.11049.49.camel@localhost.localdomain \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=dwmw2@infradead.org \
    --cc=htejun@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®