From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] libata-eh: Remove layering violation and duplication when handling absent ports
Date: Tue, 26 Sep 2006 20:27:21 +0100 [thread overview]
Message-ID: <1159298841.11049.291.camel@localhost.localdomain> (raw)
In-Reply-To: <451964E1.4090304@pobox.com>
Ar Maw, 2006-09-26 am 13:35 -0400, ysgrifennodd Jeff Garzik:
> Alan Cox wrote:
> > This removes the layering violation where drivers have to fiddle
> > directly with EH flags. Instead we now recognize -ENOENT means "no port"
> > and do the handling in the core code.
> >
> > This also removes an instance of a call to disable the port, and an
> > identical printk from each driver doing this. Even better - future rule
> > changes will be in one place only.
> >
> > Signed-off-by: Alan Cox <alan@redhat.com>
>
> applied, but please stop adding trailing whitespace
I will have a further discussion with the source code of the joe editor.
I thought I'd fixed that.
prev parent reply other threads:[~2006-09-26 19:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-26 16:53 Alan Cox
2006-09-26 17:35 ` Jeff Garzik
2006-09-26 19:27 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1159298841.11049.291.camel@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®