From: David Woodhouse <dwmw2@infradead.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Jeff Garzik <jgarzik@pobox.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
David Howells <dhowells@redhat.com>,
Al Viro <viro@ftp.linux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] restore libata build on frv
Date: Tue, 26 Sep 2006 21:21:09 +0100 [thread overview]
Message-ID: <1159302069.3309.46.camel@pmac.infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0609260909470.3952@g5.osdl.org>
On Tue, 2006-09-26 at 09:15 -0700, Linus Torvalds wrote:
> That NO_IRQ thing should be zero, and any architecture that thinks that
> zero is a valid IRQ just needs to fix its own irq mapping so that the
> "cookie" doesn't work.
> The thing is, it's zero. Get over it.
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c
index 92be519..0cdf8ad 100644
--- a/kernel/irq/manage.c
+++ b/kernel/irq/manage.c
@@ -219,7 +219,7 @@ int setup_irq(unsigned int irq, struct i
unsigned long flags;
int shared = 0;
- if (irq >= NR_IRQS)
+ if (!irq || irq >= NR_IRQS)
return -EINVAL;
if (desc->chip == &no_irq_chip)
--
dwmw2
next prev parent reply other threads:[~2006-09-26 20:22 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-24 22:39 Al Viro
2006-09-25 10:44 ` David Howells
2006-09-25 11:26 ` Alan Cox
2006-09-25 11:04 ` Russell King
2006-09-25 11:28 ` David Howells
2006-09-25 11:27 ` David Howells
2006-09-25 12:18 ` David Howells
2006-09-25 14:20 ` Al Viro
2006-09-25 15:39 ` Alan Cox
2006-09-25 15:45 ` David Howells
2006-09-25 14:39 ` David Howells
2006-09-25 15:46 ` Alan Cox
2006-09-26 8:06 ` David Woodhouse
2006-09-26 8:52 ` Jeff Garzik
2006-09-26 8:56 ` David Woodhouse
2006-09-26 11:25 ` Alan Cox
2006-09-26 11:30 ` Alan Cox
2006-09-26 16:15 ` Linus Torvalds
2006-09-26 20:21 ` David Woodhouse [this message]
2006-09-26 17:25 ` David Howells
2006-09-25 16:04 ` David Howells
2006-09-25 16:21 ` Al Viro
2006-09-27 7:05 ` David Woodhouse
2006-09-25 12:19 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1159302069.3309.46.camel@pmac.infradead.org \
--to=dwmw2@infradead.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dhowells@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=viro@ftp.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®